Omar SobhandClaude Opus 5
08847e6a63
The python guest agent only ever worked because Firecracker's CI Ubuntu image happens to ship python3. NONE of our images do — agent-base has neither python nor git, agent-terminal has git but no python — so it could never have run in a real mission rootfs. An agent that dictates what must be installed in the image has the dependency backwards. crates/bins/fcagent is a 905K static x86_64-unknown-linux-musl binary that needs nothing from the rootfs it is dropped into. The wire is unchanged on purpose — 4-byte BE length + JSON, ops ping/exec/put/get — so microvm.rs and microvm_client.rs needed no edit at all. std has no AF_VSOCK and the workspace denies `unsafe`, so it uses the `vsock` crate. `process_group(0)` gives each command its own group without unsafe, so a command that spawns background children can be killed wholesale rather than outliving the run. A unit test caught a bug that would have broken EVERY exec: sourcing the image-env file with `. env.sh 2>/dev/null; cmd` returns rc=1 WITHOUT running cmd, because `.` on a missing file makes a non-interactive POSIX shell exit immediately. On any rootfs lacking that file every command would have failed while looking like an ordinary non-zero exit. Guarded with `if [ -f ]` now. Other places a failure must not borrow an outcome's representation: a killed command reports ok:false with no rc (not rc=124, which would read as a build failure); `get` on a missing path is an error, not an empty archive; a signalled process reports 128+signal rather than success. Verified on tank: --vm-selftest still 8/8 with the agent swapped (create 949ms, wire identical), fc-node-setup 8/8, and — the point of the change — a rootfs built from clawmates/agent-terminal:dev, which has NO python3, boots and reports `git version 2.39.5` from inside the VM. Also fixes a shell bug in fc-build-rootfs.sh: $HOME in a double-quoted default expanded on this Mac, so it looked for the node's binary under /Users/quantum on a Linux host. Co-Authored-By: Claude Opus 5 <[email protected]>
28 lines
742 B
TOML
28 lines
742 B
TOML
[package]
|
|
name = "fcagent"
|
|
version = "0.1.0"
|
|
edition.workspace = true
|
|
rust-version.workspace = true
|
|
license.workspace = true
|
|
publish.workspace = true
|
|
|
|
[[bin]]
|
|
name = "fcagent"
|
|
path = "src/main.rs"
|
|
|
|
[dependencies]
|
|
# std has no AF_VSOCK, and the workspace denies `unsafe`, so raw libc is not an
|
|
# option. This is a safe wrapper over the socket calls.
|
|
vsock = "0.5"
|
|
serde_json = { workspace = true }
|
|
tar = { workspace = true }
|
|
base64 = "0.22"
|
|
|
|
# NOTE: a `[profile.release]` here would be silently ignored — cargo only honours
|
|
# profiles at the workspace root. The binary is small enough on the default
|
|
# release profile (~1 MB static) that overriding the whole workspace's profile to
|
|
# shave it would be a bad trade.
|
|
|
|
[lints]
|
|
workspace = true
|