Omar SobhandClaude Opus 5
769e002bb3
Three phases of the approved plan, plus a correction to what the last one
claimed.
CORRECTION: skills reached ONE tier, not all of them
The previous commit said "skills can now reach a mission agent". That was
true only for the container/ZeroClaw tier — the fall-through that queues a
topology_runs row for topology_worker, which drives the executor that was
patched. compose_turn_prompt/pinned_skills_text had exactly one production
caller, and phase_runner's three other paths (composed microVM, solo
microVM, direct session) never called it. CAPABILITY-REVIEW.md said the
broad thing too; both are corrected.
Those three tiers share one task string and have no per-turn alias, so
their skills resolve per PHASE from the mission's crew and are appended
there. The container tier deliberately still injects per turn, with the
running node's own role — appending in both places would put every crew
member's skills in every turn twice.
The behavioural tests prove phase_skills_text and compose_turn_prompt work.
They cannot prove the three launch_* calls pass the composed string, and
that substitution is a one-word edit that would silently return all three
tiers to delivering nothing with every test still green. So there is also a
source-level assertion on the call sites, following the precedent in
mission_events::the_cap_is_enforced_in_one_statement. Its negative control
names the exact tier.
PROVENANCE: what an agent received, and what it said it did
Both were unanswerable. The prompt was never stored anywhere on any tier —
re-deriving it later re-runs the skill lookup against a catalogue that has
since changed, and once agents author their own skills it certainly will
have. The reasoning rows were durably write-only: pushed live once, then
never read from the database again by anything except the GC that deletes
them.
- prompt.composed records the exact bytes, on all four tiers
- the session tier writes its checkpoint record and a reasoning row,
instead of eprintln! and nothing — the same defect the solo microVM
path was fixed for, in the last tier that still had it
- narrative_for_mission reads both back
Found while doing it: the 400-event per-phase cap counted EVERY kind, so a
busy phase could push out its own phase.completed and its own provenance.
The cap now counts only the two unbounded kinds it was written for.
Negative control confirms the old behaviour dropped the prompt.
Retention is now a per-mission hold (0080) rather than a raised global —
with a test asserting unheld missions are still reaped, because an
exemption that applies to everything is not an exemption.
SELF-AUTHORING: agents apply their own skill drafts, no human click
By operator decision. level_up has generated complete drafts from a model
since it shipped; only a checkbox stood between propose and apply.
What replaces the gate is not another gate but four properties, each held
by a test:
- workspace-scoped, so a hand-authored skill can never be modified
- a draft cannot take a hand-authored skill's name. Ids are scoped and
bindings resolve by skill_id, so it could not overwrite or shadow one
anyway — but two procedures under one name means nobody reading a
transcript can tell which the agent followed, and that ambiguity is
fatal in a system where the skill is the standard being graded against
- every revision appends a skill_versions row, so it can be reverted and
a past run can be read against the text it was actually judged under
- approved_by = NULL. An agent's decision is never attributed to a person
who did not make it
Only skill_candidate applies autonomously. identity_refinement and
brain_consolidation still wait for a human: they change what an agent IS
rather than adding a procedure it can consult. State is announced at boot,
because a safety gate that changes silently is one nobody notices changed.
CLAWMATES_SKILL_SELF_AUTHORING=0 restores it.
Also: the test Postgres ran out of /dev/shm mid-suite (Docker's 64MB
default) and surfaced it during MIGRATIONS, which reads like a schema fault
and is not one. --shm-size=1g, and a pointer to the `clean` subcommand that
already existed for the 779 leaked test databases.
Full workspace suite green: 106 binaries, no failures.
Co-Authored-By: Claude Opus 5 <[email protected]>
70 lines
2.8 KiB
Bash
Executable File
70 lines
2.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Manages the persistent shared Postgres that the whole test suite points at via
|
|
# CM_TEST_DATABASE_URL (wired up in .cargo/config.toml). One long-lived server
|
|
# means cm-testkit takes its `_container: None` branch and NEVER starts a
|
|
# per-test testcontainer — so a killed/panicking/orphaned `cargo test` has no
|
|
# container to leak. `--restart unless-stopped` keeps it up across Docker
|
|
# restarts so direct `cargo test` always has a server to connect to.
|
|
#
|
|
# Usage: scripts/test-server.sh {up|down|status|clean}
|
|
# up start the server if not already running (idempotent)
|
|
# down remove the server
|
|
# status show its state
|
|
# clean drop leftover test_<uuid> databases (reclaim space without a restart)
|
|
set -euo pipefail
|
|
|
|
CONTAINER="${CM_TEST_PG_CONTAINER:-clawmates-test-pg}"
|
|
PORT="${CM_TEST_PG_PORT:-54331}"
|
|
|
|
case "${1:-up}" in
|
|
up)
|
|
if docker ps --format '{{.Names}}' | grep -qx "$CONTAINER"; then
|
|
echo "$CONTAINER already up on :$PORT"
|
|
exit 0
|
|
fi
|
|
docker rm -f "$CONTAINER" >/dev/null 2>&1 || true
|
|
# --shm-size: Docker defaults /dev/shm to 64MB. Postgres allocates parallel
|
|
# query segments there, and the suite runs many tests at once against many
|
|
# databases, so the default is exhausted mid-run — surfacing as
|
|
# `could not resize shared memory segment ... No space left on device`
|
|
# during MIGRATIONS, which reads like a schema fault and is not one.
|
|
#
|
|
# Space exhaustion has a second cause with the same symptom: cm-testkit
|
|
# creates a database per test and drops none, so they accumulate across
|
|
# runs (779 of them, once). `$0 clean` sweeps those.
|
|
docker run -d --name "$CONTAINER" --restart unless-stopped \
|
|
--shm-size=1g \
|
|
-e POSTGRES_PASSWORD=postgres \
|
|
-e POSTGRES_DB=postgres \
|
|
-p "${PORT}:5432" \
|
|
postgres:16-alpine \
|
|
-c fsync=off -c full_page_writes=off -c max_connections=300 >/dev/null
|
|
until docker exec "$CONTAINER" pg_isready -U postgres -q >/dev/null 2>&1; do
|
|
sleep 0.5
|
|
done
|
|
echo "$CONTAINER up on :$PORT"
|
|
;;
|
|
down)
|
|
docker rm -f "$CONTAINER" >/dev/null 2>&1 || true
|
|
echo "$CONTAINER removed"
|
|
;;
|
|
status)
|
|
docker ps -a --filter "name=^/${CONTAINER}$" \
|
|
--format '{{.Names}} | {{.Status}} | {{.Ports}}' || true
|
|
;;
|
|
clean)
|
|
# Drop every transient test database to reclaim space (cm-testkit creates
|
|
# test_<uuid> per test and does not drop them). Safe to run anytime.
|
|
docker exec "$CONTAINER" psql -U postgres -tAc \
|
|
"SELECT datname FROM pg_database WHERE datname LIKE 'test\_%'" \
|
|
| while IFS= read -r db; do
|
|
[ -n "$db" ] && docker exec "$CONTAINER" dropdb -U postgres --force "$db" || true
|
|
done
|
|
echo "dropped leftover test_* databases"
|
|
;;
|
|
*)
|
|
echo "usage: $0 {up|down|status|clean}" >&2
|
|
exit 2
|
|
;;
|
|
esac
|