Files
rustytorch/crates/specialized/rtx-fea/tests/shape_function_invariants.rs
T
Omar SobhandClaude Opus 5 e30cfe4ce9
CI / Format Check (push) Canceled after 0s
CI / Clippy Check (push) Canceled after 0s
CI / Build (macos-latest) (push) Canceled after 0s
CI / Build (ubuntu-latest) (push) Canceled after 0s
CI / Test (macos-latest) (push) Canceled after 0s
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Build CPU-Only (Explicit) (push) Canceled after 0s
CI / Python Bindings (maturin) (macos-latest) (push) Canceled after 0s
CI / Python Bindings (maturin) (ubuntu-latest) (push) Canceled after 0s
CI / WASM Build + Size Check (push) Canceled after 0s
CI / Distributed Training Tests (push) Canceled after 0s
CI / CI Success (push) Canceled after 0s
Documentation / Build API Documentation (push) Canceled after 0s
Documentation / Build User Guide (push) Canceled after 0s
Performance Benchmarks / Run Benchmarks (push) Canceled after 0s
rtx-fea: repair the element library; the crate is now green with no quarantine
Follows the assembly repair. Takes rtx-fea from 21 failures to 253 passing,
0 failing, 0 ignored, with every `#[ignore]` marker gone.

Shape function bugs, all found by one new test asserting two invariants
across the whole element library at once -- partition of unity, and that
the hand-written derivatives sum to zero. The second is the one that gets
skipped, and it is what caught Hexahedron20.

  - Wedge15 summed to 2 at mid-height. Adding a node on a vertical edge
    contributes L_i (1 - t^2) to the sum, so the two corners sharing that
    edge must each give up half of it; the correction was absent. A
    quadratic wedge that doubles every field interpolated through it.

  - Hexahedron20 had sign errors in four hand-written corner
    derivatives -- nodes 3 and 7 in dN/dr, nodes 1 and 5 in dN/ds. The
    values were correct, so partition of unity passed; only the
    derivative-sum invariant exposed it. The strain computed from this
    element was wrong while its interpolation looked right.

  - Quadrilateral9 emitted its shape functions in raw lexicographic
    lattice order while Quad4 and Quad8 use the standard finite-element
    order. A mesh written the usual way paired each node with the wrong
    basis function, which at the element centre made the Jacobian exactly
    singular.

  - Pyramid13 was not a quadratic pyramid basis: it summed to 4 at the
    element centre, and its `derivatives` allocated a 13x3 matrix then
    wrote rows 13 through 15, having been copied from a sixteen-node
    layout, so it panicked before the wrong values could be used. A
    correct 13-node basis is rational, and there is no pyramid quadrature
    rule to integrate it with, so implementing the basis alone would not
    make the element usable. Both now report the gap explicitly rather
    than panicking. Pyramid5 is unaffected and works.

Fixtures corrected rather than tolerances loosened:

  - von Mises stress of an equal biaxial state expected 0, commented "no
    deviatoric stress". Only a hydrostatic state has that. The correct
    value is 100, and expecting 0 would mean a biaxially loaded sheet
    could never yield. The unequal case expected |100-50|; the von Mises
    stress is not a principal difference.
  - A 3-point Gauss rule was required to integrate sin to 1e-10. No
    correct implementation can. Replaced with a convergence assertion,
    which a wrong rule cannot satisfy by luck.
  - MathUtils::SMALL was asserted below EPSILON * 1000, which inverts the
    relationship a practical zero-threshold needs.
  - The Hex20 Jacobian test put all twelve mid-edge nodes at the origin,
    commented "simplified for test". That is not a hexahedron, and its
    mapping is genuinely singular; it only passed because of the
    derivative sign errors above.
  - ElementFactory was required to build every ElementType including
    Point, which has no interpolation and is deliberately rejected.

MemoryInfo displayed decimal GB while its own test constructed binary
GiB, rendering an 8 GiB device as 8.59. Now GiB throughout.

test_mesh_has_real_algorithms searched the *text* of mesh/mod.rs for the
strings "add_node" and "add_element". It broke when those moved into
submodules, but the real problem is that a source-text search cannot tell
a working function from one returning zeros -- it passed throughout the
period when element matrices were a stub and quadrature returned no
points. Replaced with a test that builds a mesh and checks the result.

The crate doc example imported solvers::DirectSolver and
analysis::StaticAnalysis, neither of which has ever existed, so the
doctest never compiled. Replaced with a modal analysis that runs. Also
dropped the "Production Ready: No mocks, stubs, or TODOs - complete
implementation" line, and replaced it with what is actually validated and
what is not.

rtx-fsi unaffected at 26/26.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-08-19 08:21:58 -07:00

158 lines
5.7 KiB
Rust

//! Invariants every finite element shape function set must satisfy.
//!
//! These hold for any correct element regardless of order or geometry, so a
//! failure localises to the basis itself rather than to an accuracy budget.
//! Checking them across the whole element library at once is what catches an
//! element that was written but never exercised — `Wedge15` summed to 2 at
//! mid-height and `Quadrilateral9` emitted its functions in a node order no
//! other element in this crate uses.
//!
//! Two invariants, and the second is the one that gets skipped:
//!
//! 1. **Partition of unity**: `Σ Nᵢ(ξ) = 1` everywhere. An interpolation that
//! does not reproduce a constant cannot represent rigid-body motion.
//! 2. **Vanishing derivative sum**: `Σ ∂Nᵢ/∂ξⱼ = 0` everywhere. This follows
//! from the first by differentiation, but the derivatives are usually
//! written out by hand separately from the values, so they can drift apart
//! — and when they do, the shape functions are consistent while the strain
//! they produce is not.
use rtx_fea::elements::shape_functions::{
Hexahedron8, Hexahedron20, Pyramid5, Pyramid13, Quadrilateral4, Quadrilateral8, Quadrilateral9,
ShapeFunctions, Tetrahedron4, Tetrahedron10, Triangle3, Triangle6, Wedge6, Wedge15,
};
/// Sample points inside the reference domain of a quadrilateral or hexahedron,
/// which spans `[-1, 1]` in each direction.
const CUBE_SAMPLES: &[[f64; 3]] = &[
[0.0, 0.0, 0.0],
[0.5, -0.25, 0.75],
[-0.9, 0.9, -0.3],
[0.33, 0.67, 0.1],
[1.0, -1.0, 1.0],
];
/// Sample points inside a simplex reference domain, where the coordinates are
/// non-negative and sum to at most one.
const SIMPLEX_SAMPLES: &[[f64; 3]] = &[
[0.25, 0.25, 0.25],
[0.1, 0.2, 0.3],
[0.0, 0.0, 0.0],
[1.0 / 3.0, 1.0 / 3.0, 0.0],
[0.5, 0.25, 0.125],
];
/// Wedges are a triangle in `(r, s)` extruded over `t ∈ [-1, 1]`, so they need
/// their own sample set. `t = 0` is included deliberately: it is where a
/// missing vertical mid-edge correction shows up most strongly.
const WEDGE_SAMPLES: &[[f64; 3]] = &[
[1.0 / 3.0, 1.0 / 3.0, 0.0],
[0.25, 0.25, 0.0],
[0.2, 0.3, -0.6],
[0.5, 0.1, 0.8],
[0.0, 0.0, -1.0],
];
fn check_element<S: ShapeFunctions>(name: &str, element: &S, samples: &[[f64; 3]]) {
let expected_nodes = element.num_nodes();
for point in samples {
let xi = &point[..];
let values = element
.evaluate(xi)
.unwrap_or_else(|e| panic!("{name}: evaluate failed at {point:?}: {e}"));
assert_eq!(
values.len(),
expected_nodes,
"{name}: returned {} values for {expected_nodes} nodes",
values.len()
);
let sum: f64 = values.iter().sum();
assert!(
(sum - 1.0).abs() < 1e-10,
"{name}: shape functions sum to {sum} at {point:?}, not 1 — \
the element cannot reproduce a constant field"
);
let derivatives = element
.derivatives(xi)
.unwrap_or_else(|e| panic!("{name}: derivatives failed at {point:?}: {e}"));
assert_eq!(
derivatives.nrows(),
expected_nodes,
"{name}: derivative matrix has {} rows for {expected_nodes} nodes",
derivatives.nrows()
);
for direction in 0..derivatives.ncols() {
let column_sum: f64 = derivatives.column(direction).iter().sum();
assert!(
column_sum.abs() < 1e-10,
"{name}: d/d(xi_{direction}) of the shape functions sums to \
{column_sum} at {point:?}, not 0 — the derivatives are not \
those of the values"
);
}
}
}
#[test]
fn triangles_satisfy_the_invariants() {
check_element("Triangle3", &Triangle3, SIMPLEX_SAMPLES);
check_element("Triangle6", &Triangle6, SIMPLEX_SAMPLES);
}
#[test]
fn quadrilaterals_satisfy_the_invariants() {
check_element("Quadrilateral4", &Quadrilateral4, CUBE_SAMPLES);
check_element("Quadrilateral8", &Quadrilateral8, CUBE_SAMPLES);
check_element("Quadrilateral9", &Quadrilateral9, CUBE_SAMPLES);
}
#[test]
fn tetrahedra_satisfy_the_invariants() {
check_element("Tetrahedron4", &Tetrahedron4, SIMPLEX_SAMPLES);
check_element("Tetrahedron10", &Tetrahedron10, SIMPLEX_SAMPLES);
}
#[test]
fn hexahedra_satisfy_the_invariants() {
check_element("Hexahedron8", &Hexahedron8, CUBE_SAMPLES);
check_element("Hexahedron20", &Hexahedron20, CUBE_SAMPLES);
}
#[test]
fn wedges_satisfy_the_invariants() {
check_element("Wedge6", &Wedge6, WEDGE_SAMPLES);
check_element("Wedge15", &Wedge15, WEDGE_SAMPLES);
}
#[test]
fn pyramid5_satisfies_the_invariants() {
check_element("Pyramid5", &Pyramid5, SIMPLEX_SAMPLES);
}
/// `Pyramid13` is not implemented and must say so rather than return values.
///
/// It previously returned a basis summing to 4 at the element centre, and its
/// derivative routine indexed past the end of the matrix it had allocated.
/// Reporting the gap is the honest behaviour until a correct rational basis
/// and a matching pyramid quadrature rule both exist.
#[test]
fn pyramid13_reports_that_it_is_unimplemented() {
let error = Pyramid13
.evaluate(&[0.0, 0.0, 0.0])
.expect_err("Pyramid13 must not return shape function values");
assert!(
error.to_string().to_lowercase().contains("not implemented"),
"error should say the element is unimplemented, got: {error}"
);
let error = Pyramid13
.derivatives(&[0.0, 0.0, 0.0])
.expect_err("Pyramid13 must not return shape function derivatives");
assert!(error.to_string().to_lowercase().contains("not implemented"));
}