17 Commits

Include renames

Author	SHA1	Message	Date
Omar Sobh	26904e37d8	PERF-2 P1.b: the polyline index prunes from the start with an upper bound from each chunk's first vertex (never the answer; the strict-minimum scan rule is unchanged), so a query near the polygon's far end no longer scans every chunk; pin unchanged, 0 mismatches	2026-09-15 23:35:40 -05:00
Omar SobhandClaude Fable 5.1	e0b5983436	PERF-2 P1.2: the overlap map's cell classification skips the point location for background cells outside the patch's node bounding box (no patch cell can contain them and the body lies inside the patch: Active, the class the search returns); PatchMesh::bounding_box ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01YJPeT6WA2e7YvAnS875AHL	2026-09-15 23:34:40 -05:00
Omar SobhandClaude Fable 5.1	01830e5c8d	PERF-2 P1: exact chunked polyline index for the O-grid's sliding outer ring — PolylineIndex::nearest returns nearest_on_polyline's point bit for bit (same segments, same order, same strict minimum; chunks skipped only when their box is farther than the best by more than 1e-12 relative), used by the Winslow sweep and the two ring projections; pin: 0 mismatches over 39,864 queries on a 3,166-point rounded outline including vertices, mid-points and ties ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01YJPeT6WA2e7YvAnS875AHL	2026-09-15 23:08:09 -05:00
Omar Sobh	11f71b832c	rtx-cfd: the regeneration profile block sits above the too_many_arguments attribute, not between it and its function	2026-09-15 22:53:40 -05:00
Omar SobhandClaude Fable 5.1	1547d14ff1	PERF-2 P0-b: CG iterations per Poisson solve in the profile (ms per V-cycle) and sub-timers inside the patch regeneration (outline, hull + offset, ring projection, Winslow sweeps, respace, warm bookkeeping, mesh finalisation) ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01YJPeT6WA2e7YvAnS875AHL	2026-09-15 22:53:26 -05:00
Omar SobhandClaude Fable 5.1	1c98156653	rtx-cfd: the deformed-tip outline chooses the flat / semicircle branch against the UNDEFORMED half-thickness — at the semicircle setting the deformed tip's radius breathes by nanometres and flipped the topology (143 → 144 points) within the first steps of the P6-b ny 41 cap-12 release at every α; pin: the point count is fixed under ± 1e-6 thickness breathing at h 10 / 6.6 mm and ny 41, semicircle and flat ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01YJPeT6WA2e7YvAnS875AHL	2026-09-15 11:13:55 -05:00
Omar SobhandClaude Fable 5.1	415c32ab04	overset mesh: the flat-tip outline (P5-3 option B) — cylinder_flag_outline_deformed_tip / cylinder_flag_patch_deformed{,_from}_tip take the tip's corner radius (t = the recorded semicircle, bit for bit; smaller = the benchmark's flat face between corner arcs sampled at the wall spacing, point count fixed across the deformation, the tip's corners kept off the hull source); pins: corner t reproduces the recorded outline, the 2.5 mm outline has the exact area excess with no collapsed spacing, the O-grid builds straight and at ± 80 mm cold and warm at ny 41/62; harness knob RTX_FSI2O_TIP_CORNER (default 0.01) on the cold and warm builds, printed in both headers; pinned-toolchain fmt on touched crates ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01LzcjQX7tvgn87CQCyg9Cfr	2026-09-13 22:22:08 -05:00
Omar SobhandClaude Fable 5.1	06229dd9a2	rtx-cfd: the deformed cylinder–flag build's hull source carries the deformed outline — the cylinder + tip disc alone give the chord under a bent flag's convex side (P5-2 died at tip −35 mm with the patch 4.4 h thick where 6 h was asked, an acceptor's donor on a prescribed face); the death reproduced from the last saved instant by extrapolating the interface (fsi2_overset_probe_death_from_instant, with the failing acceptor's ray geometry and the overlap depths that build) and gone with the fix at every τ; RTX_FSI2O_ROWS; the zero-displacement mesh gate at 1e-5 (the pipeline's), the outline gate 1e-12 unchanged ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_0116sg1Qz1gMv9hdcKP1XUam	2026-09-07 10:25:46 -07:00
Omar SobhandClaude Fable 5.1	3a68048934	rtx-cfd: cylinder_flag_patch_deformed_from — the warm-started regeneration (P5's cost lever): the previous patch's interior and its outer ring projected onto the new offset polygon as the start, and an IDEMPOTENT build (one Winslow sweep alternating with the ray re-spacing; the P4-0 one-shot is not a fixed point — measured as the interior moving 0.05 h per build at rest), so a base converged as that map's fixed point stays put (9e-11 h at rest) and each build tracks the outline (interior/wall motion 0.99–1.14, worst angle 74.7°, wall row 0.37 h) 4.5× faster than the cold build; the rigid generator untouched (pins pass); fsi2 overset harness: RTX_FSI2O_WARM_SWEEPS with the converged base as the initial patch and the committed step's mesh as each step's warm start ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_0116sg1Qz1gMv9hdcKP1XUam	2026-09-07 09:10:05 -07:00
Omar SobhandClaude Fable 5.1	d74571e21a	rtx-cfd: the deformed cylinder–flag outline's edge fractions come from the UNDEFORMED straight edge (x_tip_ref), so the patch topology is the mesh family's and not the deformation's — the P5-1 gate run died at the first bend with set_mesh refusing 143 → 144 wall cells; the P5-0 test now gates ns across amplitudes (143 at −80 / +40 / +80 mm) ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_0116sg1Qz1gMv9hdcKP1XUam	2026-09-07 07:34:26 -07:00
Omar SobhandClaude Fable 5.1	c2451fbacf	rtx-cfd: P5-0 — cylinder_flag_patch_deformed / cylinder_flag_outline_deformed: the O-grid around the cylinder and the FEA's deformed flag edges (FlagEdges bottom / tip / top), edges resampled at the rigid outline's graded arclength spacing, root fillets from the rigid construction, the tip semicircle from the deformed tip's centre and axis; the O-grid body factored out (o_grid_from_outline, hull_source) and the rigid generator kept bit-identical (its pins pass); gates: zero displacement reproduces the rigid outline to 6e-17 (mesh 2.5e-8 through the hull/Winslow pipeline, recorded), ±80 mm cantilever shapes valid at 80° with wall row 0.43 h, along-body 0.196 h, wall nodes on the edges to 6e-17, ny = 41 overlap builds ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_0116sg1Qz1gMv9hdcKP1XUam	2026-09-07 07:10:01 -07:00
Omar SobhandClaude Fable 5.1	45ff34da8f	rtx-cfd: overset P4-0 — the O-grid around the Turek–Hron rigid body (cylinder + flag), gated ... patch_gen::{cylinder_flag_outline, cylinder_flag_patch, winslow_smooth, respace_rays} (+ convex_hull, offset_convex_polygon, nearest_on_polyline): the outline CCW then reversed to clockwise (tip semicircle 16 cells, junction fillets of a FIXED radius with 3 cells, straights graded 0.3 h → h, cylinder arc at h); the outer ring the 6 h normal offset of the body's convex hull; initial pairing by the inner point's normal offset projected onto the hull offset (an arclength-proportional pairing folded the transfinite grid at the tip: rays crossed where the curvatures differ); Winslow (TTM) smoothing of the interior with the outer nodes SLIDING along the hull offset (each re-placed at the nearest point to the extrapolated ray), then re-spacing along the smoothed rays to the across stretch. Gates (tests/patch_cylinder_flag.rs): ny = 41/62/82 → 143×12 / 183×12 / 225×12 cells, positive, wall row 0.23 h (fillet max 0.37 / 0.43 / 0.50 h), worst non-orthogonality 76.6 / 69.1 / 63.3° at the concave fillets (structural: a concave arc's normals converge at its centre), classification of the benchmark background with both donor invariants. P0 MMS on these meshes (tests/cylinder_flag_mms.rs, exact acceptors, line-implicit): Stokes orders 2.17 / 2.13, upwind 2.00 / 1.86 (cell Péclet ≈ 0.1), divergence ≤ 9e-14 — the fillet skew costs nothing measurable. Rule: a refinement ladder's geometry must be fixed in physical units — with fillet = h/2 the Stokes orders read 1.74 → 1.31, the O(h) boundary perturbation masquerading as a scheme defect; the fillet is a parameter (5 mm across the ladder). Also: the P3b knock-outs H1/H2 on the balanced default (no effect), the P3 §5.10 record in the falsifier's header. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-09-05 19:50:14 -07:00
Omar SobhandClaude Fable 5.1	e2edff9b1d	rtx-cfd: overset A-P3 — the falsifier plate on the overset (FAILS the registered gates by one order less than the staircase); wall force; composite pressure-level pin; Schwarz stall detection ... patch_gen::{stadium, graded_fractions}: the falsifier plate as a stadium O-grid (semicircular ends r = half-thickness; 16 cells per end arc, straights graded 0.30 h -> h at 1.15, offset 6 h, 12 rows stretched 4x; 148x12 cells, every ray a normal, worst non-orthogonality 4 deg). CurvilinearPisoSolver::surface_force (+ PatchLoad): F = sum(-p_f S_f + mu (grad u + grad u^T)_f . S_f) on the wall faces with the wall cell's LSQ gradients (wall Dirichlet in the velocity fit); HELD on the phantom circle against the exact stress integral: 1.3e-2 / 6.3e-3 / 3.6e-3 at n = 32/64/128 (orders 1.05 / 0.81), 22x the staircase's accuracy. OversetPisoSolver: the composite p' level pinned to zero mean over the active cells every round (the coupled problem is pure Neumann; the temporal warm start handed each step's level to the next — background pressure 1e7 growing 5e4 per step on the falsifier; an unpinned level also inflated the relative Schwarz stop); stall detection (no progress over three rounds = the inner solvers' noise floor; 6560 of 150k steps burned the 20-round cap at n = 64, a 7.5 h n = 128 march); schwarz_stalled in the result. tests/overset_falsifier.rs (records; RTX_OVERSET_FALSIFIER_STRICT asserts the registered gates, _LADDER runs dt/2 and dt/4, _TRACE the top-12 spike steps): max spike 594 / 981 / 1720 N/m at dt / dt/2 / dt/4 (staircase 6490 / 12600 / 25600), rms spike 61-89 (810), far probe 502-1509 (7900), KE injection 0.16-0.21 J/m per event on the common cell set (2.6) — every large spike a ~104-cell full-row reclassification; exponent -0.77 (-1.0). The registered 5% gate (8.75 N/m) is missed 68x: the overset's own reclassification impulse is the finding (omni-cortex overset_metal_campaign.md §5.10); P3b = locate per cell, then the fringe flux balance. tests/patch_stadium.rs, curvilinear_loads.rs, overset_common::plate_patch. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-09-05 04:32:43 -07:00
Omar SobhandClaude Fable 5.1	c63d79c300	rtx-cfd/rtx-fsi: overset A-P0 GATED + M1 precision probe — curvilinear collocated PISO: relative-reduction pressure stop (the absolute stop floored |du/dt| at 2e-4 on 64²), line-implicit-n sign fix, adjustPhi; gates: Cartesian reduction 1.37–1.40x the staggered error at orders 0.83/0.90; skewed stretched periodic annulus Stokes orders 2.30/2.06 (explicit and line-implicit), upwind 1.08/0.80; Poiseuille exact to 1e-9 on Cartesian and affine-sheared periodic channels (both diffusion variants), varying-skew channel order 2.02 (v 1.9), cell mass 1e-14; divergence ≤ 1e-11 relative every step; snapshot/restore bit-identical. M1: poisson.rs multigrid hierarchy generic over MgScalar (f32/f64), f64 CG keeps its own fine level; MgPrecision on MultigridParameters/EmbeddedParameters/PisoParameters, set_poisson_precision, harness RTX_FSI2_POISSON_F32 (march + noise probe, printed marker); f64 arm bit-identical in vivo (FSI2 default line-for-line with 08-31), f32 arm holds the noise floor and stall pins and the FSI2 band; poisson_equivalence f32 arm ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-09-04 12:40:43 -07:00
Omar SobhandClaude Fable 5.1	52da75a3a9	rtx-cfd: curvilinear collocated PISO on a structured patch (overset A-P0, WIP) — PatchMesh (right-handed s,n; periodic seam with shift; face metrics), patch generators (TFI, skewed annulus, sheared/varying-skew channels), CSR + Jacobi-BiCGSTAB, the Zang–Street–Koseff incremental step with the node-based 9-point L_f, LSQ gradients, explicit and line-implicit-n predictors, adjustPhi; tests: mesh metrics (5 green), operators exact on linear fields incl. the seam (green), sparse (2 green), MMS ladder (Cartesian 16/32: 1.37–1.39x the staggered error, order 0.83; n=64 stalls at a |du/dt| floor 2e-4 — open, tolerance-scaling hypothesis), annulus/Poiseuille not yet run ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-09-04 05:00:08 -07:00
Omar SobhandClaude Opus 5	bfd9f4dfd2	rtx-cfd: repair the pressure-velocity coupling, LBM walls and mesh quality ... Clears the rest of the quarantine. All three crates now run 558 tests with 0 failures and no `#[ignore]` markers. SIMPLE could not converge, and the reason was not slow convergence but wrong physics. The pressure correction equation used a bare Laplacian, 1/dx^2 and 1/dy^2, while the velocity correction divided by a_p = rho dx dy / dt. SIMPLE requires these to be each other's inverse: substituting the corrected velocities into continuity must reproduce the pressure equation, which fixes a_E = rho d dy/dx with d = dV/a_p. The two disagreed by roughly 1/(h^2 dt) -- about 2e4 on a 16x16 cavity -- so the pressure correction was that many times too weak to enforce continuity. The consequence was visible and specific. A lid-driven cavity at Re=100 produced a monotonic profile rising from 0 at the floor to 1 at the lid: Couette flow, with no recirculation anywhere, and a peak pressure of 1.6e-4 against the rho U^2 scale of 1. The return flow in a cavity is driven entirely by the pressure gradient, so with the pressure pinned near zero there was nothing to turn the flow around. With the coefficients made consistent the profile recirculates, the peak pressure is 2.9, and the solver converges. Also in SIMPLE: - `p'` was never reset between outer iterations. It is a correction that `pressure_update_step` folds into `p`, so carrying it forward applied the same correction twice. - The convergence measure was the inner Gauss-Seidel residual, which goes to zero whether or not the flow satisfies continuity. Now the mass imbalance. - The velocity correction used only the transient part of a_p, `rho dV/dt`, rather than the diagonal the momentum equation was actually solved with. - All four convective face fluxes were computed from a single cell-centred velocity, so `fe` and `fw` were the same number, as were `fn` and `fs`. Upwinding then picked the same direction on opposite faces of the control volume. Now interpolated per face on the staggered grid. Not claimed: agreement with Ghia, Ghia & Shin (1982). The vortex centre moves toward their y = 0.4531 under refinement (0.400 at 16^2, 0.419 at 32^2, 0.460 at 64^2) but the minimum centreline velocity reaches only -0.130 against their -0.2109, and the converged field still depends slightly on the pseudo-time step, which a true steady state cannot. The cavity test therefore asserts what is established -- convergence, recirculation, vortex position, and an O(1) pressure field -- and the remaining gap is recorded in omni-cortex/docs/solver_status.md rather than papered over with a loose tolerance. LBM bounce-back was doing neither of the things its name claims. It was written as assignment (`f[2] = f[4]`) rather than a swap, discarding the population being reflected -- bounce-back is a permutation and conserves mass exactly, so the domain leaked 0.013% of its mass every 100 steps and would have kept draining. And the pairs used were 5<->8 and 6<->7, which reverse only the wall-normal component: that is specular reflection, a free-slip wall, so the no-slip condition the walls were supposed to impose never held. Mesh quality: - Quadrilateral aspect ratio included the diagonals in the maximum but not the minimum, so it could never return 1: a unit square reported sqrt(2) and a 2:1 rectangle sqrt(5). - Triangle aspect ratio used longest-over-shortest edge, which does not detect the failure mode that matters. A sliver with vertices (0,0), (10,0), (5,0.1) scores 2.0 -- indistinguishable from a healthy 2:1 triangle -- while its area is a twentieth of what its edges suggest. Now the radius ratio R/2r, which is 1 for equilateral and 1250 for that sliver, and which also fixes the quality histogram. - StructuredMesh aspect ratio took bounding-box extents and guarded the z-extent with `.max(1e-10)`. On a 2-D mesh the depth is exactly zero, so the guard became the minimum and a unit square reported 2e10. Mesh refinement produced meshes that failed their own validation. `subdivide_triangle` reserved midpoint ids as `next_node_id + k`, then advanced the counter by 3, after which `refine_cells` called `add_node` and advanced it three more -- so every refined cell referenced vertices three ids away from the ones actually created. Separately, the position lookup selected by slot rather than by id ("This is simplified, should look up correct midpoint"), so three of four sub-triangles had their areas computed from the wrong points; the quadrilateral version mapped every new id to the cell centre. Fixtures corrected rather than tolerances loosened: a structured mesh test asserted 0.16 for the average cell volume while the comment beside it computed 0.25 from the node-count convention the code actually uses; the Zou-He pressure test built a *velocity* boundary at u = 1.2, far above the lattice speed of sound, making the density negative; and the cavity-setup test required the lid to influence the domain centre 16 rows away in 10 steps, which exceeds the lattice propagation speed. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>	2026-08-19 08:40:09 -07:00
redclawsystems	4d88dc0584	Initial commit	2026-03-04 00:08:42 +00:00