10 Commits

Include renames

Author	SHA1	Message	Date
Omar SobhandClaude Fable 5.1	172a26dee4	PERF-2 P0: intra-step profiler — StepTimers on the overset solver (RTX_PROFILE; overlap build / predictors / patch BiCGSTAB / background Poisson with its setup-vs-iterate split / round exchange / apply / end exchange), PoissonSolution carries setup_ns and iterate_ns, the harness times advance / restore / snapshot / load sampling / force / FEA predictor and prints the wall split of the coupled phase; no clock is read when profiling is off; the reclassified/step progress denominator fixed (was ×4) ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01YJPeT6WA2e7YvAnS875AHL	2026-09-15 22:25:52 -05:00
Omar SobhandClaude Fable 5.1	c3dbd5040a	P6-b design 2: the Robin wall on the patch's Inner side — RobinWall { alpha, datum } with the wall velocity u_s + (t_f − datum)/α (explicit, damped by the wall's own viscous gain μ/(α d)) and the compliant-wall pressure term |S| p'/α implicit in the projection (the added-mass operator in the fluid's own response); Dirichlet bit for bit when off; MMS pin on the skewed annulus (orders 2.46/2.13 at α = 10 and 100 μ/h, the Dirichlet values; a 1e12 wall reproduces Dirichlet to 2e-6); OversetPisoSolver::patch_mut; harness knob RTX_FSI2O_ROBIN_ALPHA with the previous pass's tractions as the datum, printed in the header ... Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01YJPeT6WA2e7YvAnS875AHL	2026-09-15 10:46:35 -05:00
Omar SobhandClaude Fable 5.1	afd1bff6ee	rtx-cfd: overset A-P2 — the patch overlaps the background (OversetPisoSolver), gated S1–S5 ... Background = the embedded solver with a mask from the overlap classification (embedded/{mod,projection}.rs: module split, projection's solve/apply halves, set_overlap, fringe p' Dirichlet by elimination into extra_diag/rhs, anchor dropped, set_inner_stop_factor, phase API begin_step/solve_correction/ apply_correction/end_step; advance rebuilt on the phases — every suite digit- identical, FSI2 default line-for-line). Patch = the curvilinear solver with an acceptor ring (set_side_velocity; set_acceptor_ring/stamp_acceptors/ set_acceptor_correction; acceptor Dirichlet by elimination into PressureSystem.links so the BiCGSTAB stop stays in flux units — identity rows measured unconverged at 2431 iterations; same phase API). overset/overlap.rs: OverlapMap — hole/fringe/active from the patch's own indices (hole = body or k <= nn-1-overlap_rows, DEFAULT_OVERLAP_ROWS = 4 from the 2.9 h depth budget), dual-quad inverse-bilinear donors patch→fringe, lattice donors →acceptors, both invariants asserted, mass-defect measures. overset/mod.rs: OversetPisoSolver — advance (exchange rebuilt BEFORE the predictors from the previous corrected field), alternating Schwarz on the acceptor p' vector with Anderson(3) (plain Schwarz measured 0.82/round: floating patch, Neumann wall) and the previous step's vector as warm start (1 round/corrector at steady state), stop relative to the STEP's p' scale (the MG absolute stop is 1e-9/dt² in pressure — the whole second correction), set_patch_mesh, snapshot/restore carrying the warm-start vector. Gates: overlap linear-exact 1e-13, quadratic orders 1.96/1.99 (acceptors), 1.40/1.91 (fringe); half-couplings: patch with exact acceptors Stokes 2.07/1.98 + 2.08/1.98, upwind 0.84/0.84, background with exact fringe 7.86e-3/2.90e-3/ 1.09e-3 (1.44/1.41); two-mesh MMS n=32/64: background 8.717e-3/4.207e-3 (1.03x/ 0.97x the embedded circle), patch 1.322e-2/6.904e-3 (1.5-1.6x), orders 1.05/ 0.94, patch div <= 5e-13, overlap mass defect 3.6e-3 -> 8.2e-4 of the overlap flux (under the registered 1e-3 from n=64; disclosed at 32); motion: stationary patch through set_patch_mesh bit-identical, snapshot/restore with a pending mesh bit-identical, translating phantom circle 1.22x/1.19x the static level over 4.5 cells. Inherited, disclosed: poisson_equivalence's no-body multigrid pin fails by 3.9e-9 at d46fb0b (M1's commit; verified in a clean worktree). Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-09-04 19:24:13 -07:00
Omar SobhandClaude Fable 5.1	c9492d3e1e	test(rtx-cfd): fresh-cell falsifier extended (circle body, far-field probe, kinetic energy, speed knob) + print-only divergence trace; two candidate fixes REFUTED on it (swept-volume source 40x worse at either sign; fresh-face field extension no effect), both kept default-off with their verdicts ... Phase 1 of omni-cortex docs/fresh_cell_gcl_campaign.md. The mechanism of the moving-body force spikes is measured from four directions: per-flip force amplitude ∝ 1/dt, kinetic energy injected per flipped cell 0.048 J/m independent of dt and body shape (plate row vs circle), felt at a far-field pressure probe, and ∝ U^2 (2.60 / 0.64 / 0.15 J/m at U = 1 / 0.5 / 0.25). A binary mask's wall position jumps by one cell at every flip and the fluid answers with a fixed impulse. Neither the swept-volume source (the wall faces already carry the swept volume — the source double-counts it) nor the fresh-face velocity is where it lives. Next: the virtual cut cell in the projection (apertures + the wall-relative divergence), registered in the campaign doc. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-09-03 11:40:28 -07:00
Omar SobhandClaude Fable 5	6c48e53998	rtx-cfd: indexed polygon SDF — bit-identical queries, the fluid's measured hot function cut ... The 2026-08-30 fluid profile (symbolized samples, rigid AND coupled phases of the FSI3 default) attributed the fluid step to the function: polygon_signed_distance 51% rigid / 35% coupled — the embedded mask rebuild and its ghost reconstruction walk every edge of the ~150-vertex interface polygon for every cell-centre and face query, every step. (Also measured, refuting the parked consolidation: Level::new — the MG hierarchy build — is 0.5-0.7% in BOTH phases; caching it would buy nothing. The MG smoother at 34-40% is the honest remaining fluid cost.) PolygonSdf (solvers/incompressible/polygon_sdf.rs): a binned edge index whose query is BIT-IDENTICAL to polygon_signed_distance by construction — per-edge distances use the same float ops, the ring search provably visits a superset of the argmin (convex-projection lower bound sqrt(d_out^2 + ((r-1)b)^2)), and parity XORs the same ray tests over exactly the straddling edges (y-binned). Equality is ASSERTED, not assumed: tests compare to_bits against the brute force over ~40k adversarial points (flag-like walks, random polygons with degenerate zero-length edges, horizontal-edge/vertex-y rays). Wired into EmbeddedBody::polygon and the FSI harness's shared geometry (rebuilt per set_geometry, ~microseconds for 150 edges). Verification — the bar for a bit-exact change is digit identity, and it holds: FSI2 and FSI3 committed defaults reproduce EVERY printed digit of the banded-LU baseline logs (uy 3.7732±3.7920 / 6.0229± 25.2190 mm, conservation 8.26e-12 / 1.49e-12, rigid drags 121.4 / 426.9); rtx-cfd full suite 0 failures; rtx-fsi lib/piston/transfer/ FSI1 green. The study pins need no re-run: the trajectories are unchanged by construction and confirmed by measurement. Wall clock: FSI2 rigid 323 -> 167 s (1.93x), whole default 400 -> 225 s; FSI3 rigid 420 -> 250 s (1.68x), whole default 539 -> 343 s. Cumulative with the banded LU this session: FSI3 default 944 -> 343 s (2.75x), FSI2 524 -> 225 s (2.33x). Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-08-30 07:47:42 -05:00
Omar SobhandClaude Fable 5	bff84ccdcc	rtx-cfd: mask hysteresis — sticky cell classification against a reference mask ... The measured FSI3 killer is the bistable mask: one geometry (|d| identical to 4 digits) samples two load branches (60 vs 120 kN), and the traced s=1 death is the secant walking a 20x load cliff (68,886 -> 1,307,938 N over a 1e-3 candidate change). A sticky band makes the load map single-valued at the crossing: formerly-fluid cells flip only at phi < -band, formerly-solid at phi > band, classified against the mask held at rebuild time — in a coupling loop, the restored committed step-start mask. Band 0 is structurally bit-identical (phi > -0.0 <=> phi > 0.0) and verified digit-for-digit on both committed defaults (FSI2 and FSI3, every physics digit). Measured cost on the translating-circle MMS at band 0.25h: +0.5% field error (u/p ratios 1.17/2.12 vs the no-hysteresis moving levels 1.16/2.11); flip delay = band/(v dt), deterministic. Exposed as RTX_FSI{2,3}_HYST in multiples of h_min. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-08-26 15:27:09 -05:00
Omar SobhandClaude Fable 5	4534d90684	rtx-fea + rtx-cfd: the single-step seams FSI2 stands on ... rtx-fea: NonlinearDynamicAnalysis refactored onto a NonlinearDynamicStepper - set_nodal_forces on both (the interface load of a coupling subiteration, replaceable between steps and between subiterations of one step); - step(&DynamicState) is a pure function of the start-of-step state and the current forces - commits nothing, so a partitioned coupling re-runs one Newmark step to the interface fixed point (the piston semantics); - run() marches through the same stepper: one code path, pinned from both ends (linear limit, CSM3, and a new manual-drive == run() assertion); - new test: a nodal step load oscillates about the *static* nonlinear analysis's deflection (cross-code-path, mean within 3%, amplitude 6%), with re-run determinism and force-swap sensitivity asserted mid-march (a one-step response to a force change is ~ beta dt^2 - the first assertion draft demanded 10% and was corrected against the physics). rtx-cfd: the subiteration seam and the moving no-slip closure - EmbeddedPisoSolver::snapshot()/restore() (mask + time + init flag; the mask is now Clone): re-running a fluid step within a subiteration is bit-identical to never having diverted - proven on a moving body with cells flipping in the re-run window; - polygon_interface_velocity: nearest-edge linear interpolation of per-vertex velocities, exact for the linear-along-edge boundary data a finite-element interface hands over - the no-slip closure that replaces FSI1's zero-velocity polygon. Suites: rtx-fea 567, rtx-cfd 325, rtx-fsi piston+transfer - all green. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-20 20:00:49 -07:00
Omar SobhandClaude Fable 5	c0f5a86f03	rtx-cfd: the embedded-body pieces FSI1 stands on (belongs with b82f307) ... EmbeddedMask::traction_at (the per-sample traction factored out of surface_force, so a coupling loop can load a structure at its own quadrature points), EmbeddedBody::polygon and the public polygon_signed_distance (a deformable interface as a vertex list, usable behind a lock through EmbeddedBody::from_sdf). Left unstaged by mistake in b82f307 — that commit's FSI1 test needs these to compile. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-20 17:22:44 -07:00
Omar SobhandClaude Fable 5	0ad31abb6b	rtx-cfd: F2 — the moving embedded body, and falsifier 3 measured ... EmbeddedPisoSolver::set_moving_body: the mask is rebuilt at the end-of-step geometry every step, and the new mask's ghost values are reconstructed FROM THE PREVIOUS CORRECTED FIELD (EmbeddedMask:: impose_from — the boundary-history principle extended to a moving wall), so a stationary body run through the moving path is bit-identical to the static path, which is the first test. A velocity face that flips solid -> fluid enters the new interval holding exactly the ghost reconstruction the previous step left on it — a consistent near-wall value, not garbage; a fresh pressure cell is refilled from its fluid neighbours before the predictor's gradient can read the value it kept while inside the body. The body must move under a cell per step (the convective dt limit already enforces this for bodies slower than the local peak velocity). EmbeddedResult reports fresh_cells. tests/embedded_moving.rs: - a stationary body through the moving path: 0.0 difference over 100 steps (and zero fresh cells, identical ghost corrections); - a circle (r = 0.2) translating through the steady manufactured field with the exact field as its surface velocity — the solution must hold still while the mask sweeps 84 cells fresh over 300 steps at n = 32: max L2 velocity error 9.85e-3 = 1.16x the static steady level (8.489e-3), max L2 pressure error 4.67e-2 = 2.11x the static level (2.22e-2), bulk |div u| 1.6e-7, projection residual 5.9e-9 every step. That pressure ratio is the geometry decision's falsifier 3 (omni-cortex docs/turek_hron_geometry_decision.md): fresh-cell transients sit at ~2x the static discretisation error, not orders above it — the falsifier does not fire and no cut cells are needed. Measurement note, recorded in the test: the divergence of body-adjacent cells read after the end-of-step ghost re-imposition is a one-step lag by design (the next projection honours the re-imposed prescribed fluxes — the same lag the static path has); the continuity claims are the projection residual and the bulk divergence over all-fluid-faced cells. Deferred: an oscillating-cylinder benchmark against published force histories (Duetsch et al. 1998) when the FSI rungs need it. rtx-cfd 321 -> 323 green. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-20 13:07:28 -07:00
Omar SobhandClaude Fable 5	c25f15b3c4	rtx-cfd + rtx-fea: embedded-boundary PISO and total-Lagrangian SVK — the first two Turek–Hron rungs ... The Turek–Hron geometry decision (omni-cortex docs/turek_hron_geometry_decision.md) chose an embedded boundary on the fixed Cartesian MAC grid over body-fitted unstructured ALE; this commit builds the first rung on each side of the ladder, verified MMS-first. rtx-cfd — solvers::incompressible::{embedded, embedded_body}: EmbeddedPisoSolver is the fixed-grid PISO predictor/projection with per-side domain boundaries (ALE's SideBoundary semantics, so the channel has an outlet), a (x, y, t) boundary-velocity function, and an optional EmbeddedBody (signed distance + surface velocity; circle / rectangle / union). EmbeddedMask classifies cells (fluid iff phi > 0 at the centre) and faces (fluid iff both cells fluid; ghost within 1.5 h; solid deeper); the predictor updates fluid faces only, the projection enforces continuity on fluid cells with zero coefficient across prescribed faces, ghost faces are re-imposed after each projection from a boundary-intercept least-squares linear fit (exact for linear fields), the net ghost mass flux is removed uniformly so a Neumann projection stays compatible, and loads come by two routes: surface-stress reconstruction (full viscous traction) and a control-volume momentum balance. Verified (tests/embedded_mms.rs, tests/turek_hron_cfd.rs): - no body, closed box: bit-identical to PisoSolver over 200 steps; - embedded off-centre circle MMS 16/32/64: velocity orders 0.92, 0.97 (plain PISO 0.85, 0.91), pressure 0.96, 0.90, max |div u| <= 9e-8 on every fluid cell, compatibility correction 6e-4 -> 3e-5; force on the circle vs the exact surface integral: surface route 0.52 -> 0.29 -> 0.15, control-volume route 0.61 -> 0.30 -> 0.15 (both first order, two unrelated readings of the same solution); - Turek–Hron CFD1 (Re 20, h = 10 mm, flag two cells thick), settled to four digits: surface drag 15.71 / lift 0.94, control-volume drag 15.62 / lift 1.08 vs reference 14.29 / 1.119 — the drag routes agree to 0.6%, both +9.5%. A coarse first number; the refinement study waits on a multigrid projection (SOR: 0.1 s/step at 250x41 in the test profile). Fourteenth defect of the campaign: the fixed-grid PISO predictor zeroes the transverse convective face velocity on its domain sides (exact for walls); carried into a solver with an outlet it dropped the OUTGOING momentum flux through the outlet side of the v control volumes, the last column accumulated, and CFD1 went NaN at t ~ 4 s. Found by printing where max |u| lived (x = 2.5) after halving dt changed nothing. Fluxes now come from the stored boundary faces on every side. rtx-fea — elements::total_lagrangian + NonlinearStaticAnalysis:: with_total_lagrangian(): Green–Lagrange strain, second Piola–Kirchhoff stress from a St. Venant–Kirchhoff law on the material's Lamé parameters (plane strain in 2-D), B_L of the current deformation, material plus geometric tangent; dead-load body force per reference volume. Verified (tests/total_lagrangian_svk.rs): - zero displacement: the plane-strain stiffness to 1e-13; - tangent = d f_int/du by central differences at 20% random displacement (Quad4, Quad8, Hex8): relative < 1e-7, symmetric to 1e-12; - a 34-degree rigid rotation produces no internal force; the small-strain routine does (negative control); - manufactured finite-strain solution, body force by FD of the exact P = F S: Quad4 orders 1.95, 1.98; Quad8 2.93, 3.03, 3.02 (an 8% amplitude, Green–Lagrange strain to -0.25 near SVK's compressive limit E = -1/3, broke Newton on fine meshes — the material, not the code; 3% is clean); - Turek–Hron CSM1 at 70x4 Quad8: u(A) = (-7.060, -65.43) mm vs (-7.188, -66.10), 1.0% / 1.8%, converging from below (35x2: -65.14); CSM2: (-0.4604, -16.79) vs (-0.4690, -16.97), 1.1% / 1.8%. rtx-cfd 293 -> 301 green (5 unit + 3 integration), rtx-fea 559 -> 564. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-20 08:51:32 -07:00