14 Commits

Include renames

Author	SHA1	Message	Date
Omar SobhandClaude Opus 5	9575b84803	style: clear the fmt gate and two lib clippy warnings ... Deferred deliberately while the TWIN-2B/2C campaign had live marches: each march is a fresh `cargo test` invocation, so reformatting `turek_hron_fsi2.rs` mid-campaign would have forced a test-binary rebuild and cost comparability for a cosmetic gate. The family closed, so this is now free. - `cargo fmt --all` across 8 files that had drifted (including the FSI2/FSI3 harnesses touched by the UMEAN/ES override commits). - `rtx-feature-store/tests/integration_tests.rs` had trailing whitespace rustfmt refused to format around ("left behind trailing whitespace" internal error), so the whole file was being skipped; stripped it and the file formats now. - Two `unnecessary_parentheses` warnings in the rtx-transformers lib (`continual/progressive.rs`, `curriculum/mod.rs`) — these were the only rustytorch warnings surfacing through omni-cortex's workspace clippy gate, which is how they were found. No behaviour change. rtx-fsi test binaries still build. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01B1feFAQxjbCRHePUdxuNra	2026-09-02 19:15:53 -07:00
Omar SobhandClaude Fable 5	045e145962	test(rtx-fsi): RTX_FSI{2,3}_ES stiffness override for the TWIN-2 parameter sweep ... The second knob of the TWIN-2 campaign (omni-cortex docs/twin2_stiffness_campaign.md): case_from_env now also reads RTX_{prefix}_ES over the case's benchmark Young's modulus, mirroring UMEAN exactly — digit-identical with the knob unset (verified in vivo on BOTH committed defaults against same-day baselines: FSI2 and FSI3 physics lines diff-clean, only compile/wall timings moved), a loud override line naming the benchmark value and E/E0 when set. The benchmark-inflow physics-band guard in both turek_hron tests widens to a benchmark-CASE guard (u_mean AND e_s bit-identical) so no measured band ever asserts off-benchmark; machinery invariants stay asserted at every inflow and stiffness. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-09-01 20:50:58 -07:00
Omar SobhandClaude Fable 5	c08abbdc4f	test(rtx-fsi): RTX_FSI{2,3}_UMEAN inflow override for the TWIN-1 parameter sweep ... case_from_env applies the knob over the case's benchmark inflow; unset, the same f64 flows and both committed defaults are verified digit-identical in vivo (physics lines diff-clean vs same-day baselines; only wall-split timing percentages moved). Physics bands in both tests are guarded to benchmark inflow — an off-benchmark march (the sweep) asserts machinery invariants only; its bands live in the TWIN-1 composition harness (omni-cortex docs/twin_composition_campaign.md). The override prints loudly so sweep logs are self-describing. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-08-31 21:25:30 -07:00
Omar SobhandClaude Fable 5	4aec4e589d	rtx-cfd/rtx-fsi: the FlowField->clawview exporter — real FSI fields through the viewer, end to end ... The march gains RTX_FSI{2,3}_FFLD (MarchConfig::ffld_dir, off by default): every snap_every committed steps (10 when SNAPEVERY is 0), dump the committed FlowField (FlowField::save, bit-exact), the solver's own fluid-cell mask and the interface polygon as text sidecars, plus an index.csv. Reporting-only after acceptance; the FSI2 default with the knob off reproduces every printed digit of the warm-start baseline (uy 3.4921 +- 3.5109, conservation 8.25e-12). The exporter (rtx-cfd examples/ffld_to_vtk): a dump directory -> clawview-readable legacy VTK — per-snapshot 2D triangle meshes (one selectable point scalar --field p|umag|vort, the 0/1 fluid mask as integer CELL_DATA) and an optional space-time volume (--spacetime: frames stacked along z = time, prisms split to tets, POINT_DATA phi), which clawview's slice-plane animation plays as a transient movie. Verified end to end with REAL fields, not synthetic: a 29-frame FSI3 release-transient dump (t 4.0 -> 4.1, 64 MB) exported to 29 snapshots + a 984,312-tet space-time volume; the clawview server loaded both (176,320 nodes volume; 23,877-node snapshots) and served live cross-sections (time slices), vorticity isosurfaces and contours from them. The check caught two real viewer-contract constraints now encoded in the exporter: clawview's legacy-VTK path parses CELL_DATA scalars as INTEGER markers only, and supports exactly ONE point scalar (all POINT_DATA blocks append into `phi`) — multi-field snapshots need the .clwv route, out of scope here. Closes the top open thread of the fifteenth-session handoff (the FSNP/FlowField->viewer exporter); the mesh-repo push and the claw-gds cargo feature remain clawview-side items. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-08-30 14:45:54 -05:00
Omar SobhandClaude Fable 5	9fe9d7f74a	rtx-cfd + rtx-fsi: ECSW campaign phase 1 — snapshot dump + FlowField save/load ... FlowField::save/load serialize the complete field state bit-exact (all twelve matrices including *_old, predictors and sources, so a load is a true restart state), with a roundtrip test asserting to_bits equality on every value and rejection of truncated/corrupt files. The march gains an ECSW snapshot knob (RTX_FSI{2,3}_SNAP path, SNAPEVERY, default off): every N committed steps it appends an FSNP record — t, full-DOF displacement/velocity/acceleration (what rtx_fea::mor's pod_basis/train_ecsw consume, plus what the phase-4 dynamic reduction will need) and the committed sparse nodal load for the offline full-vs-reduced replay. Reporting-only: reads committed state after acceptance, no float ops on the solver path. Verified: smoke run's FSNP parsed by an independent reader (570 DOFs, correct record count, physical values); FSI2 committed default digit-identical with the knob off. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-08-28 21:56:37 -05:00
Omar SobhandClaude Fable 5	bff84ccdcc	rtx-cfd: mask hysteresis — sticky cell classification against a reference mask ... The measured FSI3 killer is the bistable mask: one geometry (|d| identical to 4 digits) samples two load branches (60 vs 120 kN), and the traced s=1 death is the secant walking a 20x load cliff (68,886 -> 1,307,938 N over a 1e-3 candidate change). A sticky band makes the load map single-valued at the crossing: formerly-fluid cells flip only at phi < -band, formerly-solid at phi > band, classified against the mask held at rebuild time — in a coupling loop, the restored committed step-start mask. Band 0 is structurally bit-identical (phi > -0.0 <=> phi > 0.0) and verified digit-for-digit on both committed defaults (FSI2 and FSI3, every physics digit). Measured cost on the translating-circle MMS at band 0.25h: +0.5% field error (u/p ratios 1.17/2.12 vs the no-hysteresis moving levels 1.16/2.11); flip delay = band/(v dt), deterministic. Exposed as RTX_FSI{2,3}_HYST in multiples of h_min. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01X2GmJXeQ2njUecEKiJZ1G2	2026-08-26 15:27:09 -05:00
Omar SobhandClaude Fable 5	992cd76449	rtx-fsi: stall acceptance as a knob (STALLX) — the floor must stay tight; only the rare-event window widens ... FSI3's developed cycle stalls (bistable mask flips at max-velocity crossings) sit at 3.5e-4 against the measured floor 6e-5: run 3 died 16% over the 5x window at t = 7.70. Riding the FLOOR up instead was measured to make it worse — run 4 at floor 1e-4 died EARLIER (t = 6.30) at a HIGHER stall (1.2e-3, 2.4x its window), because the accepted-step scatter IS the wall-velocity noise (tol/dt_c): a looser floor feeds the flip noise it is trying to pass. Keep the floor tight and widen only the counted, bounded stall window: `stall_accept` (RTX_<CASE>_STALLX, default 5 — both committed defaults bit-identical). Precedent: FSI2's s = 1 benchmark run accepted a worst stall of 5.4e-4 the same way and measured 0.1% in amplitude. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-25 05:00:56 -05:00
Omar SobhandClaude Fable 5	d2c82af91b	rtx-fea: rescue the nonlinear Newmark Newton — line search, then step subdivision ... Both FSI3 study deaths were the flag's SVK Newton returning ConvergenceFailed{60} inside a coupling pass at a violent mid-cycle load. The plain full-step Newton stays float-op identical (FSI2 and FSI3 committed defaults re-verified digit-for-digit, Newton rescues (0,0)); only on failure does the stepper retry: a backtracking line search on ||R|| (Armijo, alpha down to 2^-29 — 2^-8 was measured too shallow when the tangent K_T + M/(beta dt^2) is near singular and the solved direction enormous and inexact), then 2/4/8/16 Newmark substeps of dt/n, each line-searched. Rescues are counted and surfaced through MarchResult and both FSI test printouts. Measured before writing (tests/newton_rescue.rs): a static tip load from rest NEVER defeats plain Newton (1e6 N converges in 19 its — from a quiescent state the predictor is the current configuration and M/(beta dt^2) regularizes the walk) — pinned as a negative result; the killer is a mid-swing load REVERSAL (1e4 N tip load, 3 steps of swing at dt 5e-3, then reversed: dead in 60 its), the FSI3 turning-point shape — now rescued by the line search alone and consistent with a dt/32 reference march of the same interval (-0.341 vs -0.195 m, same branch), with determinism (bit-identical re-step) and march-continuation pinned alongside. Also: pin the s = 1 FSI2 benchmark cycle at study horizons (iqn / subcycle 1, t_end >= 16: f in [1.85, 2.0], uy amp in [70e-3, 92e-3] — the mode-2 s = 2 cycle fails both bands, so losing the benchmark cycle stays loud). Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-24 19:14:13 -05:00
Omar SobhandClaude Fable 5	c0666bf22a	rtx-fsi: C3 — FSI3 opened: the added-mass regime, its impulse artefact, and the coupler hygiene it demanded ... The march is extracted from the FSI2 test into a shared tests/fsi2_harness/march.rs (MarchConfig from env / MarchResult / window statistics), the harness parameterised by BenchmarkCase (FSI2, FSI3: inflow, solid density, modulus, rigid-flag drag reference), and turek_hron_fsi3.rs written on top (Re 200, density ratio 1, E 5.6e6). The committed FSI2 default is bit-identical through all of it — every new knob defaults to FSI2's behaviour; re-verified twice to every printed digit (uy 3.7732 / 3.7920 mm). FSI3's first contact, traced pass by pass (RTX_FSI3_TRACE), exposed the added-mass instability in its purest form and, one measured mechanism at a time, what a partitioned coupling at unit density ratio needs: - C^1 interface motion (MarchConfig::c1_interface): a constant per-step interface velocity is a velocity JUMP at each step start, and the incompressible fluid answers with an impulsive added-mass load ~ rho L dv / dt_fluid (8x the physical reaction under subcycling): 1,600 N at release, 48,000 N and a 59 mm response one step later, the flag's Newton dead the pass after. Constant acceleration from the previous end velocity to 2 dd/dt - v_n removes the impulse (loads 1,700-2,400 N). - IQN first-pass relaxation as a knob (initial_relaxation, FSI3 0.05): |1 - omega (1 + g)| must contract; 0.5 diverges past gain 3. - The divergence verdict waits for the secant (IqnIls): the exploratory second pass on a high-gain map legitimately overshoots 10x before the first secant column exists. Pinned by a gain-40 model test. - Kinematic predictor (predictor: "kinematic", velocity only): the structure-alone predictor ignores an added mass comparable to the flag's and overshoots 2-5x, drawing 5-6x loads every first pass; and NOT with the acceleration — Newmark average acceleration carries an inconsistent initial acceleration as a sign-alternating mode (d + dt v + dt^2 a / 2 predicted 22 mm at release; converged 0.14). - Quiescent release (quiescent_release): the structure-alone "consistent" initial acceleration M^-1 F ignores the added mass. - Coupler hygiene (IqnIls): a stalled or diverged step's secant columns are no longer retained (a bistable mask flip's columns extrapolated a 30 mm interface jump on the next step); two-window stagnation detection reports a plateau early instead of bouncing to the budget (a single-window test misjudged a slowly converging step and is recorded as such); trust region tightened to 10x the residual. A noise-column filter at the tolerance was measured to HURT (stalled a converging step at 5.5e-4) and is disabled (threshold 0). - The floor measured, not borrowed (fsi2_interface_noise.rs gains RTX_NOISE_CASE=fsi3): flip jumps 3.6e-4 (12x FSI2's), the subcycle-8 release map stalling near 1e-6, the subcycle-2 map converging to 9e-10; and through the release transient (flag at ~0.3 m/s) the subcycle-8 floor rides up to ~1e-3 with the motion — which moved the FSI3 default to subcycle 2 at a 3e-5 floor. FSI3 committed default (ny 62, release t = 4, t_end 4.2, subcycle 2): 581 steps, 3.8 subit/step (max 8), 0 stalls, 0 retries, conservation 4.3e-13; uy 10.1 +- 27.5 mm and ux -3.1 +- 3.2 mm over the first 0.2 s (reference cycle 1.45 +- 34.90, -2.86 +- 2.70). Machinery invariants pinned; physics bands await the study record. Rigid-flag drag 426.9 vs CFD3's 439.45 (-2.9%). The FSI2 mode-2 study pin (IQN / subcycle 2, t_end >= 16) was measured with the pre-hygiene coupler; re-verify on the next s = 2 study run. 48 lib tests green, clippy clean. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-23 19:43:02 -05:00
Omar SobhandClaude Fable 5	be04e0e233	rtx-fsi: pin the mode-2 flapping cycle under the IQN / subcycle-2 configuration ... Study horizons (t_end >= 16) under RTX_FSI2_COUPLER=iqn RTX_FSI2_SUBCYCLE=2 now assert the measured mode-2 cycle: frequency in [2.05, 2.45] Hz and uy amplitude in [45, 70] mm — bands that admit the settled cycle at either grid (ny=62: 57.6 mm / 2.227 Hz at t=16, 55.9 / 2.224 at t=30; ny=82: 57.1 / 2.236 at t=20) and reject both the wake attractor (3.73 Hz, ±17 mm) and the reference itself (1.93 Hz, ±82 mm) as material changes. The default configuration's pins are unchanged. Module docs brought up to the eleventh-session record. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-23 16:54:12 -05:00
Omar SobhandClaude Fable 5	a342e703a4	rtx-fsi: trust-region cap on the IQN step + increment-scaled stall acceptance ... The s = 1 FSI2 march (deepest rung: 1.955 Hz, ±73 mm mid-growth) found two coupler failure modes at peak motion: - run 1 (budget 12): NotConverged at residual 6.1e-4 = 9% of the step's own increment, after the history-reset retry — killed at t = 11.1 s. - run 2 (budget 30): the deeper budget let an ill-conditioned secant model extrapolate the locally violent map into a candidate interface that swept to the domain wall and crashed the mask build BEFORE any residual guard could fire (t ~ 9.9 s). Fixes, both scale-relative per the absolute-threshold rule: - STEP_CAP = 50: the full quasi-Newton step r + W alpha is capped at 50x the current residual norm, direction kept. Legitimate large Newton steps (near-marginal gains) pass; thousand-fold geometric extrapolations cannot. Pinned by a noisy-map test asserting every iterate's step stays within the cap. - The march accepts a stalled step at residual < max(5 x tolerance, 0.1 x the step's own increment) — the rare violent step near peak motion carries an order-below-increment error, counted like every stall and bounded by the existing stall-fraction assert; the retry trigger mirrors the same bound. 46 lib tests green, clippy clean. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-21 19:14:53 -07:00
Omar SobhandClaude Fable 5	d5f19ea497	rtx-fsi: IqnIls::reset_history — stale secant columns overshoot in rapid transients ... The s = 2 ladder march (resonant growth finally open: 2.3 Hz, amplitude through ±46 mm — 2.7x the wake attractor the loose coupling locked) died at t = 11.12 s with CouplingDiverged at iteration 2: the predictor left a 1e-4 first residual, and the first quasi-Newton update drove it to 1.1e-3. Cross-step secant history assumes the interface Jacobian drifts slowly; columns recorded at much smaller amplitude steered the least-squares direction wrong at 2.7x that amplitude, and the divergence guard read the overshoot as added mass. The map itself converges deeply from a clean start (the noise probe's stall measurement), so the recovery is: reset the history, retry the step once from the predictor. - IqnIls::reset_history(), with a cold-start-equivalence test. - turek_hron_fsi2: on an unaccepted coupling verdict under the IQN coupler, reset + one retry from the predictor (Aitken carries no history — a retry would repeat the identical iteration, so the path is IQN-only); retried steps counted and reported like stalls. Verified end-to-end: the re-run crossed the killing step and marched on (t = 11.18: uy +56 mm, window amp ±50 mm, 1.4 subit/step). 45 lib tests green, clippy clean. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-21 09:34:10 -07:00
Omar SobhandClaude Fable 5	140310b223	rtx-fsi: the noise floor interrogated — smoothing refuted, IQN-ILS lands, tight coupling reopened ... The tenth session ended on "lower the interface noise floor". This builds the levers and measures them, and the measurements overturn the diagnosis: - smooth_tractions: arclength moving average over the wetted surface, area-weighted, smooth normal-similarity factor so corners do not mix and the smoothed load stays continuous in the geometry. Nine unit tests. MEASURED NEGATIVE RESULT: the flip-scan floor is unchanged to 0.2% at radii 1-3h — the flip's load jump is coherent through the fluid field (mask rebuild shifts the pressure around the flipped cell), and a surface average preserves coherent shifts. Default off; the probe pins the attribution so nobody re-reaches for this lever. - IqnIls: interface quasi-Newton with inverse least squares (Degroote 2009) — filtered MGS least squares over secant columns (filter RELATIVE to column norm), cross-step history reuse, per-step set_tolerance. Model-map tests: exact on anisotropic linear maps within dim+2 passes (scalar Aitken provably cannot be), scale invariant, history reuse shortens the next step, stalls at the noise scale instead of diverging (fixture lesson: per-pass noise, not state-dependent noise — the latter has a genuine fixed point). - tests/fsi2_harness/: the FSI2 machinery extracted shared; verified pure code motion (committed release response reproduced to every printed digit). March gains RTX_FSI2_SMOOTH / RTX_FSI2_COUPLER=iqn / RTX_FSI2_REUSE knobs; pinned bands guard the default configuration. - tests/fsi2_interface_noise.rs: the probe. Flip-scan floor at subcycle 8: 3.05e-5 (pinned); smoothing attribution pinned; the cross-subcycle scan recorded but unpinned (the fixed geometry increment's wall-velocity trend, increment/dt_c, swamps the flip signal at small dt_c — a dt_c^2 scaling hypothesis died in that operationalization). THE OPERATIONAL FLOOR — the real release step subiterated at tolerance 1e-9 with residuals traced — converges DEEP at both subcycles: s8 aitken 3.4e-9 / iqn 1.6e-9, s2 both ~6.4e-10 in 5-6 passes. The flip jumps are events at specific geometries, not a floor under every step: the tenth session's subcycle-2 blowup was tolerance mis-budgeting (2e-4 held fixed while dt_c shrank), not an impassable floor. Probe bug found and fixed on the way: stale shared geometry leaked a 4.5e-5 phantom first residual into the first stall run; every measurement now resets the geometry on entry. All 924+17 tests green: lib 44 (was 27), piston 2, curved edge 1, FSI1, the committed FSI2 march (release response identical), the probe. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-21 06:42:05 -07:00
Omar SobhandClaude Fable 5	4e90177aa9	rtx-fsi: C2 — FSI2's coupled march, and the wrong attractor measured ... The unsteady coupling on the piston pattern with the real solvers: per TIME STEP, Aitken subiterations of (8x-subcycled embedded TVD/multigrid fluid <-> flag nonlinear-Newmark step), the fluid re-runnable through snapshot/restore + a field clone, the flag re-runnable because the stepper commits nothing, the moving polygon carrying the flag's actual interface velocity. Conservation 8.3e-12 over 9,263 coupled steps; the rigid phase reproduces this solver's own CFD2 values at both grids before anything couples. What the 30 s studies measured (ny = 62 AND 82, three protocols): the coupled system self-excites into a wake-forced cycle at 3.729/3.728 Hz with uy(A) +-17.3 mm at both grids - grid-converged, protocol- independent, kinematically genuine (ux locks 2x uy) - and NOT the benchmark's mode-2 resonant cycle (1.93 Hz / 81.6 mm; the flag's vacuum mode 2 is 1.9245 Hz). Diagnosis measured stepwise: the staggered phase lag starves the resonant channel (a subcycle=2 probe redirected growth to 1.9 Hz as predicted), and tighter dt_c is blocked because wall- velocity noise = displacement-tolerance / dt_c while the needed tolerance sits below the discrete interface noise floor (~1.3e-4 at full inflow, mask flips through beta dt^2/m). The route to the benchmark cycle is lowering that floor, not iterating against it. Robustness, both measured: rare wild tractions (19 samples in 2.4M) clamped at 20x the sample median - clamped, not dropped: a hard drop makes the pass discontinuous and the subiteration bounces at step scale; and Aitken "divergence" verdicts within 5x tolerance accepted as noise bounces over well-predicted steps (counted, bounded). The committed default (t_end = 7, ~9.5 min) pins the deterministic release response (uy 3.773 +- 3.792 mm, band +-35%); study horizons >= 25 s pin the measured 3.73 Hz attractor so any material change is loud. Full study record in the module docs and omni-cortex solver_status.md. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Lnyrw33Lu6rUhW42E9KHwq	2026-08-21 02:45:43 -07:00