4 Commits

Include renames

Author	SHA1	Message	Date
Omar SobhandClaude Opus 5	e30cfe4ce9	rtx-fea: repair the element library; the crate is now green with no quarantine ... Follows the assembly repair. Takes rtx-fea from 21 failures to 253 passing, 0 failing, 0 ignored, with every `#[ignore]` marker gone. Shape function bugs, all found by one new test asserting two invariants across the whole element library at once -- partition of unity, and that the hand-written derivatives sum to zero. The second is the one that gets skipped, and it is what caught Hexahedron20. - Wedge15 summed to 2 at mid-height. Adding a node on a vertical edge contributes L_i (1 - t^2) to the sum, so the two corners sharing that edge must each give up half of it; the correction was absent. A quadratic wedge that doubles every field interpolated through it. - Hexahedron20 had sign errors in four hand-written corner derivatives -- nodes 3 and 7 in dN/dr, nodes 1 and 5 in dN/ds. The values were correct, so partition of unity passed; only the derivative-sum invariant exposed it. The strain computed from this element was wrong while its interpolation looked right. - Quadrilateral9 emitted its shape functions in raw lexicographic lattice order while Quad4 and Quad8 use the standard finite-element order. A mesh written the usual way paired each node with the wrong basis function, which at the element centre made the Jacobian exactly singular. - Pyramid13 was not a quadratic pyramid basis: it summed to 4 at the element centre, and its `derivatives` allocated a 13x3 matrix then wrote rows 13 through 15, having been copied from a sixteen-node layout, so it panicked before the wrong values could be used. A correct 13-node basis is rational, and there is no pyramid quadrature rule to integrate it with, so implementing the basis alone would not make the element usable. Both now report the gap explicitly rather than panicking. Pyramid5 is unaffected and works. Fixtures corrected rather than tolerances loosened: - von Mises stress of an equal biaxial state expected 0, commented "no deviatoric stress". Only a hydrostatic state has that. The correct value is 100, and expecting 0 would mean a biaxially loaded sheet could never yield. The unequal case expected |100-50|; the von Mises stress is not a principal difference. - A 3-point Gauss rule was required to integrate sin to 1e-10. No correct implementation can. Replaced with a convergence assertion, which a wrong rule cannot satisfy by luck. - MathUtils::SMALL was asserted below EPSILON * 1000, which inverts the relationship a practical zero-threshold needs. - The Hex20 Jacobian test put all twelve mid-edge nodes at the origin, commented "simplified for test". That is not a hexahedron, and its mapping is genuinely singular; it only passed because of the derivative sign errors above. - ElementFactory was required to build every ElementType including Point, which has no interpolation and is deliberately rejected. MemoryInfo displayed decimal GB while its own test constructed binary GiB, rendering an 8 GiB device as 8.59. Now GiB throughout. test_mesh_has_real_algorithms searched the *text* of mesh/mod.rs for the strings "add_node" and "add_element". It broke when those moved into submodules, but the real problem is that a source-text search cannot tell a working function from one returning zeros -- it passed throughout the period when element matrices were a stub and quadrature returned no points. Replaced with a test that builds a mesh and checks the result. The crate doc example imported solvers::DirectSolver and analysis::StaticAnalysis, neither of which has ever existed, so the doctest never compiled. Replaced with a modal analysis that runs. Also dropped the "Production Ready: No mocks, stubs, or TODOs - complete implementation" line, and replaced it with what is actually validated and what is not. rtx-fsi unaffected at 26/26. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>	2026-08-19 08:21:58 -07:00
Omar SobhandClaude Opus 5	4c2cea36aa	rtx-fea: make the analysis stack produce physics, validated against closed form ... The census found rtx-fea could not produce a non-zero answer for any analysis type. Six defects sat between a correctly specified mesh and a natural frequency, each of which alone was fatal. Every one was found by writing the closed-form test first and confirming red. 1. Element matrices were a stub. StandardFiniteElement:: compute_element_matrices returned DMatrix::zeros for stiffness, force and mass -- and it is what GlobalAssembler calls for every element, so every global matrix in the crate was zero. Real quadrature-based stiffness and mass already existed in ElementMatrixComputer; nothing called them. Now wired, with the scalar mass matrix expanded by a Kronecker product with the spatial identity to match the interleaved per-node DOF layout its stiffness uses. 2. Quadrature returned no points. quadrature_rule built QuadratureRule::new(vec![], ..). Every integration loop iterates over rule.points, so an empty rule does not fail -- it skips the loop and yields a zero matrix. Real Gauss rules for line, triangle, quad, tet and hex existed unused; now dispatched by element type, with wedges as the triangle-line tensor product and pyramids an explicit error rather than an empty rule. 3. transform_derivatives computed J^-T * dN where dN is (num_nodes x param_dim). By the chain rule it is dN * J^-1. The two agree only when both are square and symmetric; for any element with more nodes than parametric directions -- every element -- the old form was a dimension mismatch that panicked inside BLAS. 4. MaterialDatabase::clone silently dropped every material, cloning names only, because Box<dyn Material> is not Clone. GlobalAssembler is constructed with materials.clone(), so every assembler ever built got an empty database and every analysis failed MaterialNotFound on a correctly specified mesh. Materials are immutable once registered, so the map now holds Arc and cloning shares them. 5. displacement_only numbered three displacement components on a 2-D mesh. Elements supply two, so assembly rejected every contribution. 6. to_dof_numbering pushed each node's DOFs in HashMap iteration order. When that came out [v, u] the assembler wrote the element's u row into the global v row. The result was still symmetric, still had the right rigid-body null space and still summed to the right total mass -- it simply described a structure with its axes transposed per node, and get_dof(node, DisplacementX) then pointed at the wrong row so constraints were applied to the wrong direction too. DofComponent now carries a canonical_index and the DOFs are sorted by it. ModalAnalysis is wired to real assembly and the repaired eigensolver, and takes boundary conditions, which it previously had no way to accept. The eigensolver now rejects a singular stiffness explicitly: try_inverse does not fail on a matrix singular only to working precision, so an unconstrained structure used to return rigid-body noise dressed up as low-frequency modes. Validation, 18 tests: - Element matrices: rigid translation stores no energy, exactly 3 rigid-body modes in 2-D and 6 in 3-D, consistent mass integrates to rho*V, mass positive definite, and K and M each scale only with the property they depend on. A zero matrix passes symmetry and does-not-crash checks, so these are chosen to be ones it fails. - Modal, end to end: longitudinal modes of a fixed-free bar against f_n = (2n-1)/(4L) sqrt(E/rho), within 1% on the first three, and second-order convergence under refinement. Axial rather than cantilever bending on purpose: Quad4 shear-locks, so a bending tolerance would fail for a reason unrelated to correctness. Bending is asserted as convergence from above instead, which is the honest claim for a locking element. Two fixtures corrected rather than tolerances loosened: integration_tests expected 27 DOFs for a 9-node planar mesh (3 components per node), which encoded defect 5 and contradicted comprehensive_tdd_tests asserting num_nodes * 2 for the same situation. rtx-fsi stays 26/26. No new failures; the rtx-cfd quarantine is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>	2026-08-19 08:10:57 -07:00
Omar SobhandClaude Opus 5	cca29aac8f	rtx-fea: repair the eigensolver, and stop the suite lying about the rest ... Lifts the 27 `#[ignore]` markers on rtx-cfd and rtx-fea. 21 of them fail; 6 were stale, marking components that have since been implemented. The suite now reports the truth, which means it is red. The eigensolver had three independent defects, each individually fatal. Found by writing closed-form tests first and confirming red: - The generalized reduction formed M^-1 K and ran Lanczos on it. M^-1 K has the right eigenvalues but is not symmetric even when K and M both are, and Lanczos assumes symmetry -- so it returned a wrong answer rather than an inaccurate one. On a 2-DOF spring-mass chain with M = diag(2,1) it gave 1.633 against an exact root of 1 - sqrt(2)/2 ~= 0.293. Replaced with the Cholesky reduction B = L^-1 (K - sigma M) L^-T. - Output was unsorted. nalgebra's symmetric_eigen gives no ordering guarantee and none was imposed; modal analysis names modes by index, so the ordering is part of the contract. - Eigenvectors could not be transformed back out of the Krylov basis. The Lanczos block was (n x num_iter) and the tridiagonal eigenvectors (min(num_iter, k) x k); whenever those differed the multiply panicked on a dimension mismatch -- that is, on every problem with more DOFs than requested modes, which is every real modal analysis. Lanczos now runs shift-invert by default. Plain Lanczos converges to the eigenvalues of largest magnitude and modal analysis wants the lowest, so without it the solver returns the modes nobody asked for. Also switched to full reorthogonalization, twice per step, so converged eigenvalues do not reappear as ghosts indistinguishable from genuine repeated roots. ModalResults computed f = sqrt(lambda / 2pi) instead of sqrt(lambda) / 2pi. The two agree only at lambda = 2pi, so a smoke test asserting a positive frequency would never separate them. A `#[cfg(disabled)]` module in the same file asserted the correct formula -- the module was disabled rather than the bug fixed. That module is removed; tests/eigenvalue_closed_form.rs supersedes it with every expected value derived analytically. Corrected a fixture rather than loosening its tolerance: implementation_tests expected the smallest eigenvalue of tridiag(-1, 4, -1) at order 3 to be 4 - 2 sqrt(2) ~= 1.172. The eigenvalues of tridiag(c, a, c) are a + 2c cos(k pi / (n+1)), so the true value is 4 - sqrt(2) ~= 2.586. The test had been quarantined for failing to match an expectation that was never right. rtx-fsi is untouched and stays 26/26. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>	2026-08-19 07:46:01 -07:00
redclawsystems	4d88dc0584	Initial commit	2026-03-04 00:08:42 +00:00