embedded3: GuessBasis re-export behind the cuda feature (the host-only build broke); A2 build: no convective exchange with prescribed faces (RTX_E3_EXCHANGE_CONVECTION=off, host + device bit 10, load route consistent)
CI / Build CPU-Only (Explicit) (push) Failing after 4s
Documentation / Build API Documentation (push) Failing after 4s
Documentation / Build User Guide (push) Successful in 5s
CI / Format Check (push) Failing after 12s
CI / Clippy Check (push) Failing after 37s
CI / Build (ubuntu-latest) (push) Failing after 2m48s
Performance Benchmarks / Run Benchmarks (push) Successful in 4m4s
CI / Build (macos-latest) (push) Canceled after 0s
CI / Test (macos-latest) (push) Canceled after 0s
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Python Bindings (maturin) (macos-latest) (push) Canceled after 0s
CI / Python Bindings (maturin) (ubuntu-latest) (push) Canceled after 0s
CI / WASM Build + Size Check (push) Canceled after 0s
CI / Distributed Training Tests (push) Canceled after 0s
CI / CI Success (push) Canceled after 0s

Co-Authored-By: Claude Fable 5.1 <[email protected]>
This commit is contained in:
Omar Sobh
2026-09-19 19:22:08 -05:00
co-authored by Claude Fable 5.1
parent d7250bc4cf
commit 77ecc54b24
8 changed files with 43 additions and 5 deletions
@@ -191,7 +191,9 @@ impl Mask {
scheme.face_correction(up2, un, u0)
};
let u_face = upwind(m_plus, u0, un) + delta;
convective[c] -= -rho * m_plus * (u_face - u0);
if !self.exchange_convection_off {
convective[c] -= -rho * m_plus * (u_face - u0);
}
force[c] -=
mu * cv.ap[d][1] * a_d * (un - u0) / solid_spacing(1.0);
}
@@ -208,7 +210,9 @@ impl Mask {
scheme.face_correction(up1, u0, ud)
};
let u_face = upwind(m_minus, ud, u0) + delta;
convective[c] -= rho * m_minus * (u_face - u0);
if !self.exchange_convection_off {
convective[c] -= rho * m_minus * (u_face - u0);
}
force[c] -=
mu * cv.ap[d][0] * a_d * (ud - u0) / solid_spacing(-1.0);
}