From 49ccebc863d5e32bf0d12d389fb8789252019f95 Mon Sep 17 00:00:00 2001 From: Omar Sobh Date: Wed, 16 Sep 2026 07:36:07 -0500 Subject: [PATCH] =?UTF-8?q?rtx-cfd=20legacy=20GPU=20tests:=20the=20two=20p?= =?UTF-8?q?oint-source=20Poisson=20tests=20expect=20the=20sign=20of=20?= =?UTF-8?q?=E2=88=87=C2=B2=CF=86=20=3D=20f?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../rtx-cfd/tests/gpu_kernel_comprehensive_tests.rs | 2 +- crates/specialized/rtx-cfd/tests/gpu_kernel_tests.rs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/specialized/rtx-cfd/tests/gpu_kernel_comprehensive_tests.rs b/crates/specialized/rtx-cfd/tests/gpu_kernel_comprehensive_tests.rs index b908ef4..c8f4325 100644 --- a/crates/specialized/rtx-cfd/tests/gpu_kernel_comprehensive_tests.rs +++ b/crates/specialized/rtx-cfd/tests/gpu_kernel_comprehensive_tests.rs @@ -420,7 +420,7 @@ mod gpu_kernel_tests { // Check that center has highest value let center_val = phi_result[center]; - assert!(center_val > 0.0, "Center value should be positive"); + assert!(center_val < 0.0, "Center value should be negative (∇²φ = f, a positive source)"); Ok(()) } diff --git a/crates/specialized/rtx-cfd/tests/gpu_kernel_tests.rs b/crates/specialized/rtx-cfd/tests/gpu_kernel_tests.rs index 2f7ea38..ddaccd1 100644 --- a/crates/specialized/rtx-cfd/tests/gpu_kernel_tests.rs +++ b/crates/specialized/rtx-cfd/tests/gpu_kernel_tests.rs @@ -256,7 +256,8 @@ mod cuda_tests { // Solution should be non-zero in the source region let center_idx = (ny / 2) * nx + (nx / 2); - assert!(result[center_idx] > 0.01); + // ∇²φ = f with zero boundaries: a positive source makes a NEGATIVE bump. + assert!(result[center_idx] < -0.01); // Boundaries should remain zero (Dirichlet BC) assert_relative_eq!(result[0], 0.0, epsilon = TEST_TOLERANCE);