rustyverse/rustytorch
2
0
Fork 0
Code Issues Pull Requests Actions 41 Packages Projects Releases Wiki Activity

refactor(rustytorch): full clean review 2026-04-30

Browse Source 
- fix(workspace): exclude crates/training/rtx-distributed from workspace members
  — RNCCL path deps absent in standalone checkout blocked all cargo operations
- refactor(rtx-backend-webgpu): split compute.rs (1654 lines) into compute/mod.rs
  (1040) + compute/conv.rs (628) — both within 1250-line limit
- fix(rtx-bench): add missing src/bin/main.rs declared in [[bin]] Cargo.toml entry
- fix(gitignore): narrow `bin/` exclusion to /bin/ only; add !**/src/bin/ exception
  to allow Rust source binary directories
- style(rtx-eval): 67x "literal".to_string() → "literal".to_owned() in automation,
  validation, metrics, lib, core, error modules and build.rs

All tests pass (64 tests across rtx-eval + rtx-backend-webgpu, 0 failures).
Clippy clean (-D warnings) on all changed crates.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This commit is contained in:
builder
2026-04-30 08:27:50 -07:00
co-authored by Claude Sonnet 4.6
parent fff1b7acd5
commit 301f223b91
13 changed files with 765 additions and 691 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/tooling/rtx-eval/src/validation.rs
+23 -23
View File
@@ -365,8 +365,8 @@ impl ValidationSuite {
let competitor_config = CompetitorRunConfig {
batch_size: 32,
sequence_length: 512,
precision: "fp32".to_string(),
device: "gpu".to_string(),
precision: "fp32".to_owned(),
device: "gpu".to_owned(),
num_runs: 5,
};
@@ -626,7 +626,7 @@ impl ValidationSuite {
let is_significant = p_value < self.config.significance_level;
let test = SignificanceTest {
test_name: "Welch's t-test".to_string(),
test_name: "Welch's t-test".to_owned(),
p_value,
is_significant,
effect_size: (improvement - 1.0).abs(),
@@ -731,16 +731,16 @@ impl ValidationSuite {
let platforms = vec![
Platform {
os: "Linux".to_string(),
arch: "x86_64".to_string(),
gpu: Some("RTX 4090".to_string()),
driver_version: Some("545.29.06".to_string()),
os: "Linux".to_owned(),
arch: "x86_64".to_owned(),
gpu: Some("RTX 4090".to_owned()),
driver_version: Some("545.29.06".to_owned()),
},
Platform {
os: "Windows".to_string(),
arch: "x86_64".to_string(),
gpu: Some("RTX 4090".to_string()),
driver_version: Some("545.84".to_string()),
os: "Windows".to_owned(),
arch: "x86_64".to_owned(),
gpu: Some("RTX 4090".to_owned()),
driver_version: Some("545.84".to_owned()),
},
];
@@ -1012,24 +1012,24 @@ impl Default for ValidationConfig {
cross_platform: true,
performance_claims: vec![
PerformanceClaim {
claim_id: "primary_performance".to_string(),
description: "5-8x faster performance".to_string(),
metric: "throughput".to_string(),
claim_id: "primary_performance".to_owned(),
description: "5-8x faster performance".to_owned(),
metric: "throughput".to_owned(),
claimed_improvement: 6.5,
confidence_threshold: 0.95,
benchmarks: vec![
"ImageNet".to_string(),
"GLUE".to_string(),
"VQA-v2".to_string(),
"ImageNet".to_owned(),
"GLUE".to_owned(),
"VQA-v2".to_owned(),
],
},
PerformanceClaim {
claim_id: "memory_efficiency".to_string(),
description: "35% less memory usage".to_string(),
metric: "memory_efficiency".to_string(),
claim_id: "memory_efficiency".to_owned(),
description: "35% less memory usage".to_owned(),
metric: "memory_efficiency".to_owned(),
claimed_improvement: 0.35,
confidence_threshold: 0.95,
benchmarks: vec!["All".to_string()],
benchmarks: vec!["All".to_owned()],
},
],
timeout: Duration::from_secs(3600),
@@ -1058,8 +1058,8 @@ mod tests {
let config = CompetitorRunConfig {
batch_size: 32,
sequence_length: 512,
precision: "fp32".to_string(),
device: "gpu".to_string(),
precision: "fp32".to_owned(),
device: "gpu".to_owned(),
num_runs: 5,
};