rustyverse/rustytorch
2
0
Fork 0
Code Issues Pull Requests Actions 12 Packages Projects Releases Wiki Activity

refactor(rustytorch): full clean review 2026-04-30

Browse Source 
- fix(workspace): exclude crates/training/rtx-distributed from workspace members
  — RNCCL path deps absent in standalone checkout blocked all cargo operations
- refactor(rtx-backend-webgpu): split compute.rs (1654 lines) into compute/mod.rs
  (1040) + compute/conv.rs (628) — both within 1250-line limit
- fix(rtx-bench): add missing src/bin/main.rs declared in [[bin]] Cargo.toml entry
- fix(gitignore): narrow `bin/` exclusion to /bin/ only; add !**/src/bin/ exception
  to allow Rust source binary directories
- style(rtx-eval): 67x "literal".to_string() → "literal".to_owned() in automation,
  validation, metrics, lib, core, error modules and build.rs

All tests pass (64 tests across rtx-eval + rtx-backend-webgpu, 0 failures).
Clippy clean (-D warnings) on all changed crates.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This commit is contained in:
builder
2026-04-30 08:27:50 -07:00
co-authored by Claude Sonnet 4.6
parent fff1b7acd5
commit 301f223b91
13 changed files with 765 additions and 691 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/tooling/rtx-eval/src/automation.rs
+14 -14
View File
@@ -233,8 +233,8 @@ impl BenchmarkAutomation {
// Full benchmark suite for main branch pushes
self.scheduler
.schedule_job(ScheduledJob {
id: "ci-full-suite".to_string(),
name: "Full CI Benchmark Suite".to_string(),
id: "ci-full-suite".to_owned(),
name: "Full CI Benchmark Suite".to_owned(),
categories: vec![
BenchmarkCategory::Language,
BenchmarkCategory::Vision,
@@ -252,8 +252,8 @@ impl BenchmarkAutomation {
// Quick performance check for PRs
self.scheduler
.schedule_job(ScheduledJob {
id: "ci-pr-check".to_string(),
name: "PR Performance Check".to_string(),
id: "ci-pr-check".to_owned(),
name: "PR Performance Check".to_owned(),
categories: vec![BenchmarkCategory::Performance],
schedule: Schedule::OnPR,
next_run: chrono::Utc::now(),
@@ -265,8 +265,8 @@ impl BenchmarkAutomation {
// Nightly comprehensive evaluation
self.scheduler
.schedule_job(ScheduledJob {
id: "nightly-comprehensive".to_string(),
name: "Nightly Comprehensive Evaluation".to_string(),
id: "nightly-comprehensive".to_owned(),
name: "Nightly Comprehensive Evaluation".to_owned(),
categories: vec![
BenchmarkCategory::Language,
BenchmarkCategory::Vision,
@@ -275,7 +275,7 @@ impl BenchmarkAutomation {
BenchmarkCategory::Performance,
BenchmarkCategory::Robustness,
],
schedule: Schedule::Cron("0 2 * * *".to_string()), // 2 AM daily
schedule: Schedule::Cron("0 2 * * *".to_owned()), // 2 AM daily
next_run: chrono::Utc::now() + chrono::Duration::hours(24),
last_run: None,
enabled: true,
@@ -750,9 +750,9 @@ impl CompetitorAnalyzer {
// Simplified implementation
Ok(Some(CompetitorComparison {
rtx_advantage: hashmap! {
"overall_performance".to_string() => 6.5,
"memory_efficiency".to_string() => 35.0,
"inference_latency".to_string() => 85.0
"overall_performance".to_owned() => 6.5,
"memory_efficiency".to_owned() => 35.0,
"inference_latency".to_owned() => 85.0
},
last_updated: chrono::Utc::now(),
confidence_interval: (5.2, 7.8),
@@ -792,8 +792,8 @@ mod tests {
let scheduler = BenchmarkScheduler::new(config).unwrap();
let job = ScheduledJob {
id: "test-job".to_string(),
name: "Test Job".to_string(),
id: "test-job".to_owned(),
name: "Test Job".to_owned(),
categories: vec![BenchmarkCategory::Performance],
schedule: Schedule::Manual,
next_run: chrono::Utc::now(),
@@ -812,13 +812,13 @@ mod tests {
let result = HistoricalResult {
timestamp: chrono::Utc::now(),
benchmark_name: "test".to_string(),
benchmark_name: "test".to_owned(),
category: BenchmarkCategory::Performance,
performance_score: 0.95,
accuracy: 0.92,
throughput: 1000.0,
git_commit: None,
rtx_version: "1.0.0".to_string(),
rtx_version: "1.0.0".to_owned(),
};
let add_result = detector.add_result(result).await;