ci: name the interop interpreter instead of relying on $GITHUB_PATH
CI / test (push) Failing after 1s
CI / test (push) Failing after 1s
The workflow already installed h5py into /opt/interop and set CLAWHDF5_REQUIRE_INTEROP=1, but it reached the tests only by appending that venv to $GITHUB_PATH, which Gitea's runner does not reliably propagate into test subprocesses. If `python3` resolved to the system interpreter instead, every interop suite would skip. Setting CLAWHDF5_PYTHON outright removes the question: together with REQUIRE_INTEROP the suites either run or the build goes red. Verified both directions locally — with a venv the four suites run 94 tests green; with a bogus interpreter and REQUIRE_INTEROP=1 the facade and netCDF4 suites fail 22 tests rather than skipping. Also documents creating the local `.venv` that `ci-test.sh` detects. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This commit is contained in:
@@ -33,8 +33,14 @@ jobs:
|
|||||||
/opt/interop/bin/pip install --no-cache-dir h5py numpy netCDF4 xarray
|
/opt/interop/bin/pip install --no-cache-dir h5py numpy netCDF4 xarray
|
||||||
echo "/opt/interop/bin" >> "$GITHUB_PATH"
|
echo "/opt/interop/bin" >> "$GITHUB_PATH"
|
||||||
- name: Show interop library versions
|
- name: Show interop library versions
|
||||||
run: python3 -c "import h5py, netCDF4; print('h5py', h5py.__version__, 'HDF5', h5py.version.hdf5_version, 'netCDF4', netCDF4.__version__)"
|
run: /opt/interop/bin/python -c "import h5py, netCDF4; print('h5py', h5py.__version__, 'HDF5', h5py.version.hdf5_version, 'netCDF4', netCDF4.__version__)"
|
||||||
- name: Run CI script
|
- name: Run CI script
|
||||||
env:
|
env:
|
||||||
|
# Name the interpreter outright rather than relying on $GITHUB_PATH
|
||||||
|
# reaching the test processes: if `python3` resolved to the system
|
||||||
|
# one instead of the venv, every interop suite would skip.
|
||||||
|
# CLAWHDF5_REQUIRE_INTEROP turns that skip into a failure, so the
|
||||||
|
# two together mean the suites either run or the build goes red.
|
||||||
|
CLAWHDF5_PYTHON: /opt/interop/bin/python
|
||||||
CLAWHDF5_REQUIRE_INTEROP: "1"
|
CLAWHDF5_REQUIRE_INTEROP: "1"
|
||||||
run: bash scripts/ci-test.sh
|
run: bash scripts/ci-test.sh
|
||||||
|
|||||||
@@ -499,6 +499,14 @@ cargo build -p clawhdf5-agent --features "agent,float16,accelerate,parallel,gpu"
|
|||||||
# Tests
|
# Tests
|
||||||
cargo test --workspace # all 1,650+ tests
|
cargo test --workspace # all 1,650+ tests
|
||||||
cargo test -p clawhdf5-agent # agent memory tests
|
cargo test -p clawhdf5-agent # agent memory tests
|
||||||
|
scripts/ci-test.sh # what CI runs: fmt, clippy matrix, tests,
|
||||||
|
# h5py/netCDF4 interop, no_std
|
||||||
|
|
||||||
|
# The interop suites need a Python with h5py; on a PEP 668 system that has to
|
||||||
|
# be a virtualenv. `ci-test.sh` finds `.venv` on its own, or set
|
||||||
|
# CLAWHDF5_PYTHON. Without one they skip — set CLAWHDF5_REQUIRE_INTEROP=1 to
|
||||||
|
# make that a failure instead.
|
||||||
|
python3 -m venv .venv && .venv/bin/pip install h5py numpy netCDF4 xarray
|
||||||
|
|
||||||
# Benchmarks
|
# Benchmarks
|
||||||
cargo bench -p clawhdf5-agent # agent memory suite
|
cargo bench -p clawhdf5-agent # agent memory suite
|
||||||
|
|||||||
Reference in New Issue
Block a user