From d3d73676c08b9dfabaa7b84093c0d37ec3ece38c Mon Sep 17 00:00:00 2001 From: osobh Date: Sat, 26 Sep 2026 10:28:10 -0500 Subject: [PATCH] style(format): iterate the dimensions when checking them against their maxima Co-Authored-By: Claude Opus 5.5 (1M context) --- crates/clawhdf5-format/src/dataspace.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/clawhdf5-format/src/dataspace.rs b/crates/clawhdf5-format/src/dataspace.rs index 8eb37e1..eedba2f 100644 --- a/crates/clawhdf5-format/src/dataspace.rs +++ b/crates/clawhdf5-format/src/dataspace.rs @@ -121,9 +121,9 @@ impl Dataspace { // Read max dimensions if flags bit 0 is set let max_dimensions = if flags & 0x01 != 0 { let mut max_dims = Vec::with_capacity(rank as usize); - for i in 0..rank as usize { + for &dim in &dimensions { let val = read_length(data, pos, length_size)?; - if dimensions[i] > val { + if dim > val { return Err(FormatError::InvalidDataspace( "dataspace dimension size is greater than its maximum size", ));