From c85a8222ccb0c43e163f067f48293dbd027eba4f Mon Sep 17 00:00:00 2001 From: osobh Date: Sat, 26 Sep 2026 01:38:38 -0500 Subject: [PATCH] test: compile the facade's parallel tests, and build them in CI parallel_integration.rs declared `_sequential` and used `sequential` under the parallel feature, which nothing in CI enabled for the facade. ci-test.sh now lints and tests the facade with parallel on. Co-Authored-By: Claude Opus 5.5 (1M context) --- crates/clawhdf5/tests/parallel_integration.rs | 3 ++- scripts/ci-test.sh | 12 +++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/crates/clawhdf5/tests/parallel_integration.rs b/crates/clawhdf5/tests/parallel_integration.rs index f950844..bdcf4f0 100644 --- a/crates/clawhdf5/tests/parallel_integration.rs +++ b/crates/clawhdf5/tests/parallel_integration.rs @@ -292,7 +292,8 @@ mod parallel_tests { } // Sequential decompression - let _sequential: Vec> = chunk_infos + #[cfg_attr(not(feature = "parallel"), allow(unused_variables))] + let sequential: Vec> = chunk_infos .iter() .map(|ci| { let addr = ci.address as usize; diff --git a/scripts/ci-test.sh b/scripts/ci-test.sh index bd64a50..e99cbf1 100755 --- a/scripts/ci-test.sh +++ b/scripts/ci-test.sh @@ -82,11 +82,13 @@ plugin_filters_alone() { } run_step "cargo clippy (each plugin filter alone)" plugin_filters_alone -# The facade's plugin-filter interop tests only build with the features on. -run_step "cargo clippy (facade plugin filters)" cargo clippy \ +# The facade's plugin-filter interop tests and its parallel decoding tests +# only build with those features on (parallel_integration.rs stopped +# compiling unnoticed while nothing built it). +run_step "cargo clippy (facade plugin filters + parallel)" cargo clippy \ -p clawhdf5 \ --all-targets \ - --features plugin-filters \ + --features plugin-filters,parallel \ -- -D warnings # The HNSW index's parallel bulk build is feature-gated too. @@ -180,6 +182,10 @@ run_step "cargo test (format feature matrix)" cargo test \ -p clawhdf5-format \ --features parallel,lz4,zstd,pcodec,fast-checksum,plugin-filters +run_step "cargo test (facade parallel)" cargo test \ + -p clawhdf5 \ + --features parallel + run_step "cargo test (ann parallel)" cargo test \ -p clawhdf5-ann \ --features parallel