fix(format): keep the array dimensions of compound v1 members

Browse Source

Compound datatype version 1 carries, per member, a dimensionality and four
dimension sizes (HDF5 before 1.4 had no array class). The parser skipped
those 28 bytes, so a member such as `f: f32[4]` came back as a single f32
at the member's offset: the compound's size was right but its members were
wrong. libhdf5 wraps such a member in an array type of the first
`dimensionality` sizes and ignores the permutation; do the same, and
reject a dimensionality above 4 as libhdf5 does.

Only files old enough to also use layout message v1 have these, so this
became reachable with the previous commit (tarrold.h5, tcompound.h5).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

...

This commit is contained in:

osobh

2026-09-25 21:55:31 -05:00

co-authored by Claude Opus 5.5

parent 85eb7f5ce2

commit 36356ba8a1

6 changed files with 119 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

crates/clawhdf5-format/tests/fixtures/legacy/tarrold.h5

Vendored

BIN

Binary file not shown.