Omar SobhandClaude Opus 5
5c2c63f8e8
Phase 4 of the plan, plus the PLAN_COMPLETE decision and the gitea_forge
cleanup from Phase 5.
THE REVIEW UI
mission_plan and mission_roster have been complete and reachable by curl
since they shipped, with zero frontend. That matters more than a missing
screen usually would: the decide step is not a convenience, it IS the
safety mechanism. Approving a plan replaces the mission's phases; approving
a roster flips it to the composed engine. A gate nobody can reach is a gate
that is always open or always shut.
MissionProposalDrawer, modelled on LevelUpDrawer which already does
load → review → decide. Reached from a mission's SETUP tab. Verified end to
end against the live backend, not just compiled: a model proposed a roster,
approval flipped the mission to `composed`, and approval on a non-draft
mission was refused.
The plan view shows each phase's done_when, and says plainly when one is
absent — a phase without a completion condition is never judged and reports
completed whatever it did, so its absence is the thing worth seeing.
AND THE DEFECT BUILDING IT FOUND
Every refusal path computed a precise reason — "the mission is running, not
a draft", "no node can boot that backend any more" — logged it to stderr,
and returned a bare {"error":"bad request"}. The person who needed the
sentence was the one clicking Approve; they got two words, and the reason
went to a server log they cannot read.
ApiError::Refused(String) carries it now. Same argument ApiError::Unavailable
was added for ("a 500 with 'internal error' sent them looking for a bug that
was not there"), one status code down. Live: the 400 now reads "this mission
is completed — a roster can only be approved while it is a draft, because
approving one rewrites how the mission will run".
PLAN_COMPLETE, decided
The Skill-Use measurement found that int-xx-marker-protocol documents
PLAN_COMPLETE and task_card_parser never implemented it, so an agent
following the skill exactly was silently ignored. Implemented rather than
removed from the skill: the planner needs a way to say it is done
specifying, and agents already emit it.
Marker ids are now strictly INT-<digits>. `starts_with("INT-")` accepted the
range form `INT-01..02` — observed live — which parsed into an id matching
no real item, so a task card appeared for something that did not exist while
the two items it covered stayed open. Rejecting is right: an ignored marker
is visible, a plausible row is not.
GITEA_FORGE, REMOVED
Named in nine places, defined in none. Harmless while provision_claw ignored
the bundle list; once the list was honoured, an undefined name became a
capability an agent is told it has and does not. Removed from seven team
templates, a workflow recipe, the auto-provision path, and a dropdown a user
could pick it from.
A new test asserts every bundle a template names is defined in the runtime
config — and it immediately found `web_fetch` in two templates I had missed
removing by hand. Same shape as the skill-binding test, one layer up.
Agents reach the forge through git over HTTPS with the ambient GITEA_TOKEN,
which is why nothing ever broke.
Full workspace suite green (106 binaries); frontend builds clean.
Co-Authored-By: Claude Opus 5 <[email protected]>
68 lines
2.2 KiB
TOML
68 lines
2.2 KiB
TOML
key = "mobile"
|
||
name = "Mobile"
|
||
description = "Expo + React Native for iOS/Android — camera, comms, networking, native modules."
|
||
stack = ["typescript", "react-native", "expo", "ios", "android"]
|
||
default_topology = "pipeline"
|
||
risk_profile = "coding_readwrite"
|
||
mcp_bundles = ["clawmates_door", "clawmates_skills"]
|
||
version = 1
|
||
|
||
[[roles]]
|
||
slot = "designer"
|
||
order_idx = 0
|
||
skills = ["decompose-int-items", "mobile-platform-conventions"]
|
||
system_prompt = """
|
||
You are the DESIGNER of a Mobile team.
|
||
|
||
For each INT item: define the screen's state model, navigation
|
||
integration, platform-specific behavior (safe-area on iOS, back-button
|
||
on Android), and any native-module permissions required.
|
||
"""
|
||
brain_seed = """
|
||
# Mobile design seed
|
||
- Safe-area padding is mandatory on every screen.
|
||
- Deep links go through the app's central router — never hand-crafted.
|
||
- Every permission prompt has a pre-prompt explaining WHY.
|
||
"""
|
||
|
||
[[roles]]
|
||
slot = "coder"
|
||
order_idx = 1
|
||
skills = ["expo-managed-vs-bare", "workspace-repo-commit-protocol", "int-xx-marker-protocol", "component-4-state-model", "rn-flashlist-perf"]
|
||
system_prompt = """
|
||
You are the CODER of a Mobile team.
|
||
|
||
Working directory /workspace/repo. Prefer Expo's managed workflow;
|
||
justify any drop to bare workflow. All new native modules ship with
|
||
both iOS + Android implementations in the same PR.
|
||
"""
|
||
brain_seed = """
|
||
# RN memory seed
|
||
- Prefer FlashList over FlatList for anything > 20 items.
|
||
- Reanimated for anything animating > 3× per frame.
|
||
- No inline require() — dynamic imports break Metro's tree-shake.
|
||
"""
|
||
|
||
[[roles]]
|
||
slot = "tester"
|
||
order_idx = 2
|
||
skills = ["mobile-e2e-and-simulators", "tdd-red-green-refactor"]
|
||
system_prompt = """
|
||
You are the TESTER of a Mobile team.
|
||
|
||
Detox e2e on both platforms. Snapshot tests for critical layouts.
|
||
Run on both iPhone 15 Pro simulator + Pixel 8 emulator before signing
|
||
off.
|
||
"""
|
||
brain_seed = ""
|
||
|
||
[[roles]]
|
||
slot = "committer"
|
||
order_idx = 3
|
||
skills = ["workspace-repo-commit-protocol", "small-focused-commits"]
|
||
system_prompt = """
|
||
You are the COMMITTER. Only run on green tests both platforms.
|
||
Emit COMPLETED: INT-<NN>.
|
||
"""
|
||
brain_seed = ""
|