4 Commits

Include renames

Author	SHA1	Message	Date
Omar Sobh	a2bc06d313	validation sweep: close residual TODO + strip 'future' stubs ... - mission_orchestrator: replace hardcoded cli=\"claude\" with real precedence chain: mission.config.cli → template.config.default_cli → \"claude\". Missions can now A/B by CLI without a schema change. - fleet.rs: scope clippy::too_many_arguments allow on NodeHub::open_pty — 8 params (session address x4 + target address x3) is the actual dimensionality; a struct would be ceremony. - security_scan.rs: delete future_artifact_root — pure hint-stub, no callers, nothing depends on it. - routes/world.rs: delete the empty normalize() seam + its 30-line comment block. normalize_run_event higher up does the real work; the empty stub was pre-cleanup scaffolding. Post-sweep validation across the whole workspace: * cargo check --workspace → clean * cargo test --workspace --no-run → all bins build * cargo test -p cm-api --test mission_orchestrator → 3/3 pass * cargo clippy -p cm-api -p clawmates-node --tests → 0 warnings * tsc --noEmit → 0 errors Wiring audit: every recent route handler is registered in lib.rs. Every recent frontend component has at least one importer. Remaining #[allow(dead_code)] entries are deprovision_claw + unpublish_claw on RuntimeProvisioner — real rollback paths waiting on the team-delete route. Documented future hooks, not stubs.	2026-07-20 11:41:59 -07:00
Omar Sobh	2b3ec27757	herdr phase 1c: wizard runtime picker + on_launch auto-dispatch ... Closes the operator loop for the second-runtime path. Missions created with runtime='local_herdr' now spawn a Herdr pane on their target_node automatically on draft→running. Frontend (MissionWizard): - Step 4 grows a "Runtime" section above Schedule - Radio: "Hosted (ZeroClaw)" default | "On a fleet node (Herdr)" - Local-Herdr shows a dropdown of ONLINE nodes only (from /api/nodes filtered by status='online') - canNext blocks Next when local_herdr picked without a node - Review step shows "Runtime: Herdr on <node-name>" or "Hosted" - Empty-online-nodes state hints "Connect one from INFRA first" Backend: - mission_orchestrator::on_launch grows a NodeHub param; when mission.runtime_kind='local_herdr' + target_node_id set + hub present → calls fleet_herdr::dispatch(). Non-fatal: logs and continues so a research_only mission with a Herdr runtime chosen accidentally still boots the team. - routes::missions::set_status passes state.node_hub through. - Test call sites updated to pass None for the new param (integration tests don't drive real fleet nodes). CLI stub: on_launch currently hard-codes cli="claude" for the Herdr pane. Phase 4 will read that from the team template so a research team → kimi, gpu team → claude, etc. Verified: cargo check --workspace + cargo test -p cm-api --test mission_orchestrator + tsc --noEmit all green.	2026-07-20 10:02:40 -07:00
Omar Sobh	214d0c5e9f	task #25: per-mission repo checkout on mission launch ... Closes the follow-up gap flagged when task #23 landed. security_scan and benchmark_runner now exec against $CLAWMATES_MISSIONS_ROOT/ {mission_id}/repo — this commit is what actually puts a repo there. - crates/cm-api/src/mission_workspace.rs — new module. ensure_checkout(pool, workspace_id, mission_id): * mission with no repo_id → Ok(None), no-op * repo cloned into $ROOT/{id}/repo (--depth 1) * dir already a git repo → fetch + reset --hard origin/{branch} (idempotent — every launch brings the tree in sync with the remote default_branch) Auth uses the process's ambient git credential setup (SSH agent / .netrc / helper). Tokens deliberately not embedded in URLs. - crates/cm-api/src/mission_orchestrator.rs — on_launch calls ensure_checkout after team materialization + team_id bind. Non-fatal: clone failures log and continue so research_only missions (no repo needed) don't get blocked. - deploy/compose/docker-compose.yml — new named volume missions_workspaces mounted at /var/lib/clawmates-missions on both the server (writer) and where the clawmates-runtime container will mount it (reader for docker exec). CLAWMATES_ MISSIONS_ROOT + CLAWMATES_RUNTIME_CONTAINER env vars set on the server so mission_workspace + exec_target read the same canonical values. The scan/bench trigger buttons now actually produce findings once you (a) run a mission whose repo_id is set, (b) have the clawmates-runtime container bind-mounting missions_workspaces at /var/lib/clawmates-missions. Verified: SQLX_OFFLINE=true cargo check -p cm-api + cargo test -p cm-api --test mission_orchestrator both green.	2026-07-20 04:04:36 -07:00
Omar SobhandClaude Opus 4.7	565f6cae65	slice 4: 5 workflow templates as TOML recipes + mission-launch orchestrator ... Two things land together: 1. Ships the 5 workflow recipes as TOML files under templates/workflows/*.toml: - research_only (hub_spoke research → MD + PDF) - research_and_code (research → coding loop until INT-XX drained) - security_hardening (scan → research patches → coding with reviewer approval + full MCP bundle) - refactor (single-pass coding with dep audit preamble + before/after benchmarks) - benchmark (author + baseline benchmarks per stack) Each declares phases[], per-phase config, default_team_template. Loaded read-only into an in-memory registry (workflow_registry) via OnceLock — no DB row per recipe. 2. Ships the mission-launch orchestrator that closes the loop from Slice 3.5d's mechanics. When a mission transitions draft→running, `mission_orchestrator::on_launch`: - Reads mission.team_template_id (skips if unset) - Loads the team template detail (roles + skills bindings) - Builds a topology graph from role slots via cm_topology::build - Inserts the teams row + stamps template_id/version/risk_profile/mcp_bundles - For each role: agent insert, model binding, runtime provision (opt-in via RuntimeProvisioner::from_env), brain_seed::ingest (Slice 3.5d), agent_template_link::upsert (Slice 3.5d), team_members bind, audit trail - UPDATE missions SET team_id = ... Wired into routes::missions::set_status when prior.status='draft' and new='running'. Failures log + are non-fatal (mission still flips to running so the user can inspect + retry). With this, Slice 3.5d's brain-seed + link machinery actually gets populated, and the MCP skills server's template-defaults-merge path (Slice 3.5b/d) starts serving real bindings to real agents. Follow-ups (Slice 5-8): - Task-card parser watches run events for TASK/COMPLETED markers → mission_tasks rows - PDF renderer worker turns MD artifacts into PDFs - Before/after benchmark runner honors phases[].config.benchmark - Security scan MCP bundle exposes cargo-audit/gitleaks/trivy/semgrep - Level-up endpoints diff learned-vs-seeded via agent_template_link Co-Authored-By: Claude Opus 4.7 <[email protected]>	2026-07-19 14:34:26 -07:00