feat(missions): Continuous Research harvests at launch, and cards launch by clicking
deploy / test (push) Successful in 4m21s
deploy / build (push) Successful in 5m14s

The card shipped in e20b321 could not actually be used. Three things were
missing, each of which failed at a different distance from its cause.

**1. `default_team_template` was parsed and never read.** Every recipe declares
one; `WorkflowRecipe` carries the field; nothing consumed it. A mission created
from a card with no explicitly chosen team was rejected at LAUNCH with "no
team_id, no team_template_id, no config.phase_teams" — one step removed from the
real cause, which is that creation ignored the recipe. Create now resolves it
via `team_templates::get_by_key`, only when the caller named no team of any
kind, so an explicit choice still wins. A test asserts every shipped recipe
names a template that has a `templates/teams/<key>.toml`, because a mismatch
there produces an unlaunchable card.

**2. The harvest ran nowhere.** `harvest_for_mission` existed and nothing called
it. `on_launch` now runs it for `continuous_research` missions, before the
phases start, and threads the blob store through from `main` (the route already
had it on `AppState`; the scheduler needed it). Deliberately non-fatal: a
harvest that fails still starts the phases, because the phase is what reports
whether today was quiet or broken and those must stay distinguishable — but
never silent, so both outcomes log their counts.

**3. Nothing wrote the manifest.** `templates/teams/continuous_research.toml`
has pointed its reader role at `ContinuousResearch/<date>/harvest.jsonl` since it
was authored, and the file did not exist — agents aimed at a path nothing
produced. `run_to_vault` now writes it beside the notes and stages it, but only
for a mission-attributed run. `Harvest` carries the shelved `Paper`s to build
it; re-parsing the notes we had just written would have been a parse of our own
output and one more place for the two to drift.

Also: the blob root. `storage.data_dir` defaults to "./data" and the container's
cwd is `/`, so the server tried to create `/data` as uid 65532 and EVERY shelve
failed with "storage io: Permission denied". The image now creates
/var/lib/clawmates-blobs owned by 65532 so a mounted volume inherits it rather
than arriving root:root. Kept off /var/lib/clawmates-missions on purpose: that
tree is swept, and a paper shelved there would be deleted out from under its own
catalogue note.

Proven end to end on a real mission: 15 candidates, 2 already held, 13 shelved,
0 failed; branch auto-merged as additive-only; manifest on vault `main` with
every documented key. The "already held" counts are the seen-set deduping across
topics within a single run, which is the behaviour the whole design exists for.

The project brief now comes from the mission description — `phase_task_text`
already places it under BRIEF verbatim, so no new field was needed.

346 tests pass.

Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
Omar Sobh
2026-08-17 15:05:37 -07:00
co-authored by Claude Opus 5
parent a2d7e3ea92
commit a02e0cba69
10 changed files with 222 additions and 13 deletions
+4 -1
View File
@@ -156,6 +156,7 @@ async fn reschedule(pool: &PgPool, m: &DueMission, after: OffsetDateTime) {
pub async fn tick(
pool: &PgPool,
node_hub: Option<std::sync::Arc<crate::fleet::NodeHub>>,
blobs: Option<std::sync::Arc<dyn cm_files::BlobStore>>,
now: OffsetDateTime,
) -> Result<usize, String> {
let due = claim_due(pool, now).await?;
@@ -192,6 +193,7 @@ pub async fn tick(
owner,
m.id,
node_hub.clone(),
blobs.clone(),
)
.await
{
@@ -233,6 +235,7 @@ pub async fn tick(
pub fn spawn(
pool: PgPool,
node_hub: Option<std::sync::Arc<crate::fleet::NodeHub>>,
blobs: Option<std::sync::Arc<dyn cm_files::BlobStore>>,
interval: std::time::Duration,
) {
tokio::spawn(async move {
@@ -243,7 +246,7 @@ pub fn spawn(
loop {
ticker.tick().await;
let now = OffsetDateTime::now_utc();
match tick(&pool, node_hub.clone(), now).await {
match tick(&pool, node_hub.clone(), blobs.clone(), now).await {
Ok(n) if n > 0 => eprintln!("mission_schedule: launched {n} due mission(s)"),
Ok(_) => {}
Err(e) => eprintln!("mission_schedule: sweep failed: {e}"),