feat(missions): Continuous Research harvests at launch, and cards launch by clicking
The card shipped in e20b321 could not actually be used. Three things were
missing, each of which failed at a different distance from its cause.
**1. `default_team_template` was parsed and never read.** Every recipe declares
one; `WorkflowRecipe` carries the field; nothing consumed it. A mission created
from a card with no explicitly chosen team was rejected at LAUNCH with "no
team_id, no team_template_id, no config.phase_teams" — one step removed from the
real cause, which is that creation ignored the recipe. Create now resolves it
via `team_templates::get_by_key`, only when the caller named no team of any
kind, so an explicit choice still wins. A test asserts every shipped recipe
names a template that has a `templates/teams/<key>.toml`, because a mismatch
there produces an unlaunchable card.
**2. The harvest ran nowhere.** `harvest_for_mission` existed and nothing called
it. `on_launch` now runs it for `continuous_research` missions, before the
phases start, and threads the blob store through from `main` (the route already
had it on `AppState`; the scheduler needed it). Deliberately non-fatal: a
harvest that fails still starts the phases, because the phase is what reports
whether today was quiet or broken and those must stay distinguishable — but
never silent, so both outcomes log their counts.
**3. Nothing wrote the manifest.** `templates/teams/continuous_research.toml`
has pointed its reader role at `ContinuousResearch/<date>/harvest.jsonl` since it
was authored, and the file did not exist — agents aimed at a path nothing
produced. `run_to_vault` now writes it beside the notes and stages it, but only
for a mission-attributed run. `Harvest` carries the shelved `Paper`s to build
it; re-parsing the notes we had just written would have been a parse of our own
output and one more place for the two to drift.
Also: the blob root. `storage.data_dir` defaults to "./data" and the container's
cwd is `/`, so the server tried to create `/data` as uid 65532 and EVERY shelve
failed with "storage io: Permission denied". The image now creates
/var/lib/clawmates-blobs owned by 65532 so a mounted volume inherits it rather
than arriving root:root. Kept off /var/lib/clawmates-missions on purpose: that
tree is swept, and a paper shelved there would be deleted out from under its own
catalogue note.
Proven end to end on a real mission: 15 candidates, 2 already held, 13 shelved,
0 failed; branch auto-merged as additive-only; manifest on vault `main` with
every documented key. The "already held" counts are the seen-set deduping across
topics within a single run, which is the behaviour the whole design exists for.
The project brief now comes from the mission description — `phase_task_text`
already places it under BRIEF verbatim, so no new field was needed.
346 tests pass.
Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5
parent
a2d7e3ea92
commit
a02e0cba69
@@ -153,6 +153,7 @@ pub async fn run_to_vault(
|
||||
total.shelved.extend(h.shelved);
|
||||
total.failed.extend(h.failed);
|
||||
total.notes_written.extend(h.notes_written);
|
||||
total.papers.extend(h.papers);
|
||||
}
|
||||
|
||||
// The TAIL of the uuid, not the head. UUIDv7 leads with a 48-bit
|
||||
@@ -175,7 +176,38 @@ pub async fn run_to_vault(
|
||||
}
|
||||
|
||||
git(&vault, &["checkout", "-B", &branch]).await?;
|
||||
git(&vault, &["add", "--", "60 Papers"]).await?;
|
||||
|
||||
// The run manifest, beside the notes.
|
||||
//
|
||||
// `templates/teams/continuous_research.toml` has told its reader role to
|
||||
// start from `ContinuousResearch/<date>/harvest.jsonl` since it was
|
||||
// authored, and nothing wrote it — the agents were pointed at a file that
|
||||
// did not exist. This is the code producing what the prompt already
|
||||
// promises, so "nothing new today" is a fact the agent reads rather than a
|
||||
// conclusion it guesses from an empty folder.
|
||||
//
|
||||
// Written only when the run is attributed to a mission: a plain library run
|
||||
// has no agent waiting on it and does not need the extra file in the vault.
|
||||
let mut staged: Vec<&str> = vec!["60 Papers"];
|
||||
let manifest_rel = crate::continuous_research::manifest_path(&crate::continuous_research::today());
|
||||
if mission_id.is_some() {
|
||||
let manifest_abs = vault.join(&manifest_rel);
|
||||
if let Some(parent) = manifest_abs.parent() {
|
||||
std::fs::create_dir_all(parent)
|
||||
.map_err(|e| format!("create {}: {e}", parent.display()))?;
|
||||
}
|
||||
let body = crate::continuous_research::manifest_lines(
|
||||
&total.papers,
|
||||
&crate::continuous_research::today(),
|
||||
);
|
||||
std::fs::write(&manifest_abs, format!("{body}\n"))
|
||||
.map_err(|e| format!("write {}: {e}", manifest_abs.display()))?;
|
||||
staged.push("ContinuousResearch");
|
||||
}
|
||||
|
||||
let mut add: Vec<&str> = vec!["add", "--"];
|
||||
add.extend(staged);
|
||||
git(&vault, &add).await?;
|
||||
let message = format!(
|
||||
"library: {} new paper(s)\n\n{}\n\nShelved in the blob store; this commit is the catalogue.",
|
||||
total.shelved.len(),
|
||||
|
||||
Reference in New Issue
Block a user