fix(skills): every team-template skill binding now resolves
55 of 85 role skill bindings pointed at skills that were never authored,
so 10 of 11 team templates bound a smaller context bundle than their role
prompts assumed. Three roles bound nothing at all (gpu.bench_engineer,
threejs.shader_author, threejs.perf_engineer) while their prompts described
procedures they had no way to read.
The loader comment at team_template_loader.rs:167 already diagnosed this —
snake_case slugs in TOML against kebab-case skill files — and it was
half-fixed: the kebab names were corrected, the snake_case ones left.
It was invisible because both existing tests assert authored ⊆ referenced
(30/30, green) and the second explicitly declines to check the other
direction. So the failing half was the half nobody asserted.
Resolved every name by one of three explicit choices:
- 23 skills authored where the role genuinely needed the procedure
(gpu, threejs, research, analysis, frontend, mobile, backend, platform)
- renames onto authored skills where one existed in substance, including
the four-near-duplicate cases that collapse onto one real skill
- 22 aspirational references deleted — a binding an agent cannot read is
a promise, not a capability
Two tests now hold it. The unit test checks referenced ⊆ authored against
the files. The new integration test runs both loaders in boot order and
asserts the bindings survive the trip through the database, which is a
different question: resolution goes through skills_catalog rows, so a skill
file that exists but fails to ingest still leaves the role empty.
Negative controls: the unit test failed naming all 55; the integration test
fails naming the exact role when one name is reverted.
threejs.shader_author and .perf_engineer gained a second and third skill
after the collapse — pin_in_context pins idx < 2, so a role left with one
skill silently pins less than the policy intends.
Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5
parent
ba98c29481
commit
4358964c05
@@ -10,7 +10,7 @@ version = 1
|
||||
[[roles]]
|
||||
slot = "scene_designer"
|
||||
order_idx = 0
|
||||
skills = ["decompose-int-items", "scene_graph_planning"]
|
||||
skills = ["decompose-int-items", "scene-graph-planning"]
|
||||
system_prompt = """
|
||||
You are the SCENE DESIGNER of a three.js team.
|
||||
|
||||
@@ -28,7 +28,7 @@ brain_seed = """
|
||||
[[roles]]
|
||||
slot = "coder"
|
||||
order_idx = 1
|
||||
skills = ["write_typescript", "threejs-perf-and-teardown", "workspace-repo-commit-protocol", "int-xx-marker-protocol"]
|
||||
skills = ["threejs-perf-and-teardown", "workspace-repo-commit-protocol", "int-xx-marker-protocol"]
|
||||
system_prompt = """
|
||||
You are the CODER of a three.js team.
|
||||
|
||||
@@ -47,7 +47,7 @@ brain_seed = """
|
||||
[[roles]]
|
||||
slot = "shader_author"
|
||||
order_idx = 2
|
||||
skills = ["write_glsl", "write_wgsl", "write_typescript"]
|
||||
skills = ["shader-authoring-glsl-wgsl", "webgl-frame-profiling", "workspace-repo-commit-protocol"]
|
||||
system_prompt = """
|
||||
You are the SHADER AUTHOR. Author vertex/fragment shaders (GLSL for
|
||||
WebGL, WGSL for WebGPU). Comment mathematical steps. Provide a
|
||||
@@ -58,7 +58,7 @@ brain_seed = ""
|
||||
[[roles]]
|
||||
slot = "perf_engineer"
|
||||
order_idx = 3
|
||||
skills = ["chrome_devtools_perf", "spector_js_capture", "webgl_frame_capture"]
|
||||
skills = ["webgl-frame-profiling", "threejs-perf-and-teardown", "shader-authoring-glsl-wgsl"]
|
||||
system_prompt = """
|
||||
You are the PERF ENGINEER. Profile with SpectorJS or Chrome DevTools
|
||||
Performance panel. Report per-frame breakdown (JS / GPU / paint) and
|
||||
|
||||
Reference in New Issue
Block a user