fix(skills): reconcile team-template skill names so role bindings actually bind
Every skill reference in every team template was failing to resolve. The TOMLs used snake_case slugs (`write_rust`, `index_selection`) while the authored skills under `skills/**/*.md` declare kebab-case names (`write-rust-current-edition`, `postgres-index-selection`), so `get_by_name` missed on all of them: 128 skipped bindings across 51 distinct names, and no mission agent received any of its template's skills. The mirror-image half was equally invisible: ten authored skills — including `int-xx-marker-protocol`, whose own `when_to_use` says "pin on every coding role" — were referenced by no role at all, so nothing could ever load them. - Rename the 14 references that have authored skills behind them, and dedupe the two that now collapse onto the commit-protocol skill. - Attach all ten orphaned skills to the roles their `when_to_use` names. All 23 authored skills now reach at least one role. - Aggregate the loader's per-name logging into one line per template. The old per-name spam is why this went unnoticed; a bound/unresolved count is noticeable. References with no authored skill are kept and listed — they record intent for skills not yet written. - Two regression tests: no authored skill may be orphaned, and every authored skill must be referenced by its exact name. Also clears the two standing clippy warnings: group `mint_team_from_template`'s eight positional args into `TeamMint`, and make `provider_alias_for` branch on `is_exact_provider_match` so the helper is live code and the two can't disagree about what counts as an exact family match. Co-Authored-By: Claude Opus 5 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 5
parent
95bd65540c
commit
2eb0880fc0
@@ -11,7 +11,7 @@ version = 1
|
||||
[[roles]]
|
||||
slot = "implementation_tracker"
|
||||
order_idx = 0
|
||||
skills = ["git-log-forensics", "paper-citation-parsing", "workspace-repo-commit-protocol"]
|
||||
skills = ["git-log-forensics", "paper-citation-parsing", "workspace-repo-commit-protocol"]
|
||||
system_prompt = """
|
||||
You are the IMPLEMENTATION TRACKER of an Insight Research team.
|
||||
|
||||
@@ -46,7 +46,7 @@ on it.
|
||||
[[roles]]
|
||||
slot = "novelty_hunter"
|
||||
order_idx = 1
|
||||
skills = ["structured-paper-summary", "prior-art-search", "workspace-repo-commit-protocol"]
|
||||
skills = ["structured-paper-summary", "prior-art-search", "workspace-repo-commit-protocol"]
|
||||
system_prompt = """
|
||||
You are the NOVELTY HUNTER of an Insight Research team.
|
||||
|
||||
@@ -85,7 +85,7 @@ brain_seed = """
|
||||
[[roles]]
|
||||
slot = "publication_drafter"
|
||||
order_idx = 2
|
||||
skills = ["scientific-writing-conventions", "figure-planning", "workspace-repo-commit-protocol", "small-focused-commits"]
|
||||
skills = ["scientific-writing-conventions", "figure-planning", "workspace-repo-commit-protocol", "small-focused-commits"]
|
||||
system_prompt = """
|
||||
You are the PUBLICATION DRAFTER of an Insight Research team.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user